Platform fetch performance improvements #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantoine
force-pushed
the
platform-fetch-perf-improvements
branch
from
a000df3
to
fbdf657
Compare
gantoine
force-pushed
the
platform-fetch-perf-improvements
branch
from
fbdf657
to
9fc8267
Compare
gantoine
commented
May 21, 2024
| platform.firmware_files = [ | ||
| FirmwareSchema.model_validate(f) for f in sorted(db_platform.firmware, key=lambda x: x.file_name) | ||
| ] | ||
| return platform |
There was a problem hiding this comment.
This is no longer needed since as it turns out performance is unaffected by loading firmware data as well
| return db_platform_handler.get_rom_count(self.id) | ||
| rom_count = column_property( | ||
| select(func.count(Rom.id)).where(Rom.platform_id == id).scalar_subquery() | ||
| ) |
There was a problem hiding this comment.
Significantly faster since it runs in SQL land instead of making another DB query
| } | ||
|
|
||
| return response; | ||
| }, |
There was a problem hiding this comment.
Does what it says; fires a custom event when all network requests are complete, which triggers loading things like the platforms sidebar and heartbeat data.
zurdi15
approved these changes
May 23, 2024
Merged
spiceratops
added a commit
to spiceratops/k8s-gitops
that referenced
this pull request
Jun 8, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [rommapp/romm](https://togithub.com/rommapp/romm) | minor | `3.1.0` -> `3.2.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rommapp/romm (rommapp/romm)</summary> ### [`v3.2.0`](https://togithub.com/rommapp/romm/releases/tag/3.2.0) [Compare Source](https://togithub.com/rommapp/romm/compare/3.1.0...3.2.0) ### BIOS file support We've added the ability to mount (or upload) your BIOS/firmware files for any of the supported platforms. On top of that, when playing in browser with our EmulatorJS integration, you'll now be able to select both a BIOS file to load, and a core (when the system supports more then 1 core). Refer to the EmulatorJS for the complete list of available cores for each system. ### Sharable & private notes When viewing a game, you might notice a new tab called "Notes"; this is your notepad, a blank space to jot down just about anything. With full Markdown support, you have complete control over the style and layout of your note. You're also able to make the note "public" (using the little eye icon next to the pencil), that is visible to every logged-in user on your instance. And if they do the same, you'll get access to their note, for easy sharing of tips and tricks. ||| |---|---| ||| ### Performance improvements On collections of 1000+ games/platforms with 250+ roms, we've measured a 10x to 20x improvement in load times. RomM should now feel faster regardless of the size of your collection, with smoother gallery navigation, faster loading of games on scroll, and real pagination support in the list view. #### What's Changed - Games notes by [@​gantoine](https://togithub.com/gantoine) in [rommapp/romm#828 - Copy download link dialog by [@​zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#846 - Firmware/BIOS support by [@​gantoine](https://togithub.com/gantoine) in [rommapp/romm#830 - Upgraded front packages and adapted code by [@​zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#847 - Python package changes by [@​gantoine](https://togithub.com/gantoine) in [rommapp/romm#844 - Fixed gallery play button for not supported platforms by [@​zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#848 - Fixed updating user images and ignore firmware files based on config by [@​gantoine](https://togithub.com/gantoine) in [rommapp/romm#851 - Purge platforms correctly on scan by [@​gantoine](https://togithub.com/gantoine) in [rommapp/romm#858 - Ruff-only pre-commit hooks by [@​gantoine](https://togithub.com/gantoine) in [rommapp/romm#855 - Added amiibo platform icon by [@​Casuallynoted](https://togithub.com/Casuallynoted) in [rommapp/romm#869 - Fixed emulatorjs game loading when game have non-ascii characters in the name by [@​vincywindy](https://togithub.com/vincywindy) in [rommapp/romm#872 - Fix search by ID for mobygames by [@​gantoine](https://togithub.com/gantoine) in [rommapp/romm#863 - Platform fetch performance improvements by [@​gantoine](https://togithub.com/gantoine) in [rommapp/romm#857 - Fixed uploading images for roms and users by [@​gantoine](https://togithub.com/gantoine) in [rommapp/romm#874 - Fixed rom download by [@​vincywindy](https://togithub.com/vincywindy) in [rommapp/romm#876 - Improved general performance (10x faster load at home page and galleries) by [@​gantoine](https://togithub.com/gantoine) in [rommapp/romm#875 - Fixed scan view selectors by [@​zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#878 - Whats new link fixed by [@​zurdi15](https://togithub.com/zurdi15) in [rommapp/romm#880 - Only scan platform when selected by [@​gantoine](https://togithub.com/gantoine) in [rommapp/romm#882 - Improved performance of Rom DB fetch by [@​gantoine](https://togithub.com/gantoine) in [rommapp/romm#883 #### New Contributors - [@​vincywindy](https://togithub.com/vincywindy) made their first contribution in [rommapp/romm#872 - [@​Deekerman](https://togithub.com/Deekerman) a special shoutout for being a right PITA </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODIuNCIsInVwZGF0ZWRJblZlciI6IjM3LjM4Mi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should make loading the home and gallery pages a lot snappier on large libraries.
GUNICORN_WORKERSenv variable lets users define how many workers to spin up