Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/main layout #934

Merged
merged 64 commits into from
Jun 20, 2024
Merged

Refactor/main layout #934

merged 64 commits into from
Jun 20, 2024

Conversation

zurdi15
Copy link
Member

@zurdi15 zurdi15 commented Jun 16, 2024

Features

  • Main layout refactor and redesign to improve responsiveness and navigation coherence
  • Refactor and UX improvements of all views, sections and dialogs
  • Resources structure migrated from resources/{platform_slug}/{rom_name} to resources/{platform_id}/{rom_id}.
  • Covers are now fetch in their 1080p version. Also fixes [Bug] Custom hi-res cover are still low-res. #881
  • Now sibling roms can have different covers.
  • Screenshots are fetch in their big version to work better with Feature/large carousel #932

TODO

  • Generate small version of custom cover art

Breaking change❗: Due to the resources structure migration, each rom with siblings (same game, different region, language, tag, etc) will loss the cover and a new scan/manual update will be needed. Just the main (the one that romm find first in the migration) will keep the cover.

Depends on:

Copy link

github-actions bot commented Jun 16, 2024

Test Results

73 tests  ±0   73 ✅ ±0   23s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 90030d5. ± Comparison against base commit 71fed00.

♻️ This comment has been updated with latest results.

@zurdi15 zurdi15 merged commit d01bd27 into master Jun 20, 2024
8 checks passed
@zurdi15 zurdi15 deleted the refactor/main_layout branch June 20, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request improved performance refactor Code refactor ui/ux UI/UX improvements or suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants