fix: Correctly traverse SteamGridDB API pages #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SteamGridDB API has a bug, where the `total` field for the paginated endpoint `/v2/grids/game/:gameId` sometimes double/triple counts results (e.g. returning `total=172` when there are actually 86 results). To avoid this issue, this change relies on each page's number of results. If the received page has less than the requested amount of grids, we know that is the last page.
|
Nice catch and fix! Thank you very much |
zurdi15
approved these changes
Jul 8, 2024
gantoine
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SteamGridDB API has a bug, where the
totalfield for the paginated endpoint/v2/grids/game/:gameIdsometimes double/triple counts results (e.g. returningtotal=172when there are actually 86 results).To avoid this issue, this change relies on each page's number of results. If the received page has less than the requested amount of grids, we know that is the last page.