Fix overflow check for Number as From<u64> #287

torkleyy · 2020-11-23T16:04:53Z

Now big u64 integers will correctly be mapped to a f64.

Fixes #285

Now big u64 integers will correctly be mapped to a f64

torkleyy · 2020-11-23T16:06:07Z

So while this is clearly an improvement and fixes the obvious bug, note that there's still an issue when trying to round-trip large u64 integers using Value.

kvark · 2020-11-23T16:18:12Z

src/value.rs

@@ -494,6 +494,8 @@ mod tests {
    {
        use crate::de::from_str;

+        dbg!(s);


leftover stuff

Fix overflow check for Number as From<u64>

2a739f2

Now big u64 integers will correctly be mapped to a f64

kvark reviewed Nov 23, 2020

View reviewed changes

src/value.rs

@@ -494,6 +494,8 @@ mod tests {

{

use crate::de::from_str;

dbg!(s);

Copy link

Collaborator

kvark Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover stuff

torkleyy closed this Nov 24, 2020

torkleyy deleted the fixu64 branch October 21, 2021 19:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix overflow check for Number as From<u64> #287

Fix overflow check for Number as From<u64> #287

torkleyy commented Nov 23, 2020 •

edited

torkleyy commented Nov 23, 2020

kvark Nov 23, 2020

Fix overflow check for Number as From<u64> #287

Fix overflow check for Number as From<u64> #287

Conversation

torkleyy commented Nov 23, 2020 • edited

torkleyy commented Nov 23, 2020

kvark Nov 23, 2020

Choose a reason for hiding this comment

torkleyy commented Nov 23, 2020 •

edited