Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard u128 and i128 behind optional integer128 feature #351

Merged
merged 4 commits into from Dec 23, 2021

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Dec 18, 2021

This PR adds an optional integer128 feature that guards the usage of i128 and u128. Therefore, any library using serde with either of these types should now enable the feature. This PR is heavily inspired by #304.

  • I've included my change in CHANGELOG.md

@juntyr
Copy link
Member Author

juntyr commented Dec 18, 2021

@torkleyy @kvark @caiiiycuk I've started the implementation to add an integer128 feature. So far the functionality should be there, but some aspects still have to be refactored (e.g. the serialize dispatch code duplication). What do you think of the general design? How should the CI be adapted? I know we can check if compilation for wasm succeeds, but should e.g. the tests be run as well?

Copy link
Collaborator

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I believe the direction is sound

Cargo.toml Outdated Show resolved Hide resolved
src/parse.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@juntyr juntyr marked this pull request as ready for review December 21, 2021 10:39
@juntyr juntyr marked this pull request as draft December 21, 2021 10:40
@juntyr juntyr changed the title Guard u128 and i128 behind on-by-default integer128 feature Guard u128 and i128 behind optional integer128 feature Dec 23, 2021
@juntyr juntyr marked this pull request as ready for review December 23, 2021 11:19
@juntyr juntyr merged commit 6e96c3b into ron-rs:master Dec 23, 2021
@juntyr juntyr deleted the integer128 branch December 23, 2021 11:23
@torkleyy torkleyy mentioned this pull request Jun 6, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants