Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compact_maps and compact_structs options to PrettyConfig #448

Merged
merged 1 commit into from Apr 8, 2023

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Apr 7, 2023

Fixes #447 by adding compact_maps and compact_structs options to PrettyConfig

  • I've included my change in CHANGELOG.md

@juntyr
Copy link
Member Author

juntyr commented Apr 7, 2023

?r @torkleyy

@juntyr juntyr self-assigned this Apr 7, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 77.77% and project coverage change: -0.10 ⚠️

Comparison is base (5a407f3) 86.73% compared to head (fe79095) 86.63%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   86.73%   86.63%   -0.10%     
==========================================
  Files          59       60       +1     
  Lines        7280     7364      +84     
==========================================
+ Hits         6314     6380      +66     
- Misses        966      984      +18     
Impacted Files Coverage Δ
src/ser/mod.rs 70.89% <69.23%> (-0.26%) ⬇️
tests/447_compact_maps_structs.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juntyr juntyr merged commit 2a57149 into ron-rs:master Apr 8, 2023
7 checks passed
@juntyr juntyr deleted the compact-maps-structs branch April 8, 2023 11:10
juntyr added a commit to juntyr/ron that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrettyPrint add struct compact
3 participants