Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value::from and full code lines coverage #498

Merged
merged 10 commits into from Sep 5, 2023
Merged

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Sep 4, 2023

This PR adds more tests to bring ron to 100% code lines coverage.

The PR also implements convenient From impls for Value, e.g. Value::from(bool) and Value::from("my-str").

  • I've included my change in CHANGELOG.md

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.59% 🎉

Comparison is base (9ecb1e5) 99.40% compared to head (d44413e) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #498      +/-   ##
===========================================
+ Coverage   99.40%   100.00%   +0.59%     
===========================================
  Files          78        78              
  Lines       10592     11053     +461     
===========================================
+ Hits        10529     11053     +524     
+ Misses         63         0      -63     
Files Changed Coverage Δ
src/de/tests.rs 100.00% <100.00%> (ø)
src/de/value.rs 100.00% <100.00%> (+2.03%) ⬆️
src/error.rs 100.00% <100.00%> (ø)
src/parse.rs 100.00% <100.00%> (ø)
src/value/map.rs 100.00% <100.00%> (+53.73%) ⬆️
src/value/mod.rs 100.00% <100.00%> (+5.12%) ⬆️
src/value/number.rs 100.00% <100.00%> (+3.19%) ⬆️
tests/401_raw_identifier.rs 100.00% <100.00%> (ø)
tests/465_unwrap_some_newtype_variant_value.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juntyr juntyr marked this pull request as ready for review September 5, 2023 06:46
@juntyr juntyr changed the title Full coverage Value::from and full code lines coverage Sep 5, 2023
@juntyr
Copy link
Member Author

juntyr commented Sep 5, 2023

?r @torkleyy It is possible - 100% code lines coverage 🎆 Do the Value::from impls look ok?

Copy link
Contributor

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks good to me

@juntyr juntyr merged commit 2787d8c into ron-rs:master Sep 5, 2023
8 checks passed
@juntyr juntyr deleted the full-coverage branch September 5, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants