Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholders to add #12

Open
7 of 10 tasks
Wundero opened this issue Feb 15, 2017 · 15 comments
Open
7 of 10 tasks

Placeholders to add #12

Wundero opened this issue Feb 15, 2017 · 15 comments

Comments

@Wundero
Copy link
Collaborator

Wundero commented Feb 15, 2017

List of expansions (hooks) to add:

  • Permissions hook
    • Permissions options
  • Economy hook
  • World token for Player
  • Date/Time hook
  • Unique players
  • Player ping
  • Numerous javascript placeholder starting points
  • Data placeholder -> takes in a data holder as a source, and uses tokens to determine the value to get.
    • Contextual support when that is supported

Note; placeholders involving non-Sponge systems (like plugins) should have support either implemented directly in the plugins or as a bridging plugin, for two reasons:

  • Adding dependencies to this plugin would bloat it beyond necessary levels. There is no reason to have soft dependencies as this is intended to be an API.
  • Support for this API in plugins that use it would make user support for placeholders nearly seamless
  • Bridge plugins would be a bit more bloating for the user but removes dependencies in projects that are trying to trim dependencies down; for instance, if NuVotifier ends up supporting services, a NuVotifier-PlaceholderAPI bridge would be a bridge plugin.

I will add more as suggestions come in/I come up with more.

@randombyte-developer
Copy link

BungeeCord, like the amount of all online players.

@Wundero Wundero mentioned this issue Feb 17, 2017
10 tasks
@ronaldburns
Copy link
Owner

Tried adding SpongyCord support, but the Consumers won't run when calling API tasks.
Can't get it to work.

@randombyte-developer
Copy link

Do you have a separate branch for that? I can help fixing it. @rojo8399

@randombyte-developer
Copy link

randombyte-developer commented Feb 20, 2017

Or using this. It is an updated version of SpongyCord.

@Wundero
Copy link
Collaborator Author

Wundero commented Feb 20, 2017

I think I will separate out dependency-based placeholders into their own plugins or something, so as to minimize the size of the main plugin. I will try to write a proper plugin for each of these (except maybe nucleus because of Gluon), but I need to find a bit more time first.

@Wundero
Copy link
Collaborator Author

Wundero commented Mar 6, 2017

I have written a BungeeCord placeholders plugin, but I have yet to finish writing the script and expansion browser for GH Pages, and I need @rojo8399 to add GH pages before I can commit the browser. The browser might be a while because I am new to web dev (sorta), so I need to figure out how to design and lay things out, as well as create the functions which can fetch and download files from GitHub. Once that is done I will create a folder in the root called expansions with plugins that can be downloaded and installed, and a folder called scripts which can either be downloaded as .js files or copy-pasted into the folder directly by the user.

@Wundero
Copy link
Collaborator Author

Wundero commented Mar 6, 2017

I am going to add a few things to my expansion, do some testing, and then push it to Ore hopefully. It might take a couple of days due to time constraints, but I will try to release it ASAP.

@Wundero
Copy link
Collaborator Author

Wundero commented Apr 25, 2017

I suppose I should talk about the BungeeCord placeholders since I haven't done anything recently for them: I have not had much time as of late to work on coding at all, and I was having issues prior to this lapse in time getting the placeholders to work. I now have more free time and will look into working on them again, however since I have many issues to work out before uploading it, do not expect it for some time. I apologize for the delays and hope to have a build out soon.

@randombyte-developer
Copy link

@Wundero No worries. I myself have very little time, too, since school started some days ago. I haven't even implemented PlaceholderAPI into my plugin(holograms).

@happyzleaf
Copy link

My plugin adds pixelmon support, so you don't need to
https://github.com/happyzleaf/PixelmonPlaceholders

@Wundero
Copy link
Collaborator Author

Wundero commented Jun 26, 2017

Sounds awesome. One thing to note is that, in the next update, I am going to force the Object onValueRequest(Player, Optional<String>) as the method needing implementation and provide a default implementation for the Text-based method. The boilerplate code you have in your ExpansionBase will no longer be needed. :P

@happyzleaf
Copy link

Awesome!

@BrainStone
Copy link

How's the Nucleus support going? I mean since Nucleus had its official release it would be cool if support could be added soon.

@Wundero
Copy link
Collaborator Author

Wundero commented Aug 24, 2017

Nucleus has official support through Nucleus Gluon which interconnects the two plugins. Any placeholders available through Nucleus are available through this plugin.

@KhaozFrost
Copy link

has bungee support been completely dropped? Kind of need this for my server selector to display the amount of players on a server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants