Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New blocks #19

Merged
merged 5 commits into from
Oct 26, 2021
Merged

New blocks #19

merged 5 commits into from
Oct 26, 2021

Conversation

ronaldokun
Copy link
Owner

  • Added missing block types from CRFS Documentation: Dtype3, Dtype4, Dtype5, Dtype7, Dtype8, Dtype22, Dtype23, Dtype60, Dtype61, Dtype62.

  • Added ValueError handling in all calls of np.frombuffer

  • Simplified slicing inside the properties of some blocks

Added Dtype3, Dtype4, Dtype5, Dtype7, Dtype8, Dtype22, Dtype23, Dtype60, Dtype61, Dtype62. Added ValueError handling in all calls of np.frombuffer
@ronaldokun ronaldokun self-assigned this Oct 25, 2021
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 26, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 4.33%.

Quality metrics Before After Change
Complexity 1.09 ⭐ 0.68 ⭐ -0.41 👍
Method Length 28.60 ⭐ 23.40 ⭐ -5.20 👍
Working memory 6.38 🙂 5.27 ⭐ -1.11 👍
Quality 85.71% 90.04% 4.33% 👍
Other metrics Before After Change
Lines 1450 1732 282
Changed files Quality Before Quality After Quality Change
rfpye/_nbdev.py 84.46% ⭐ 82.95% ⭐ -1.51% 👎
rfpye/blocks.py 89.04% ⭐ 92.63% ⭐ 3.59% 👍
rfpye/parser.py 75.68% ⭐ 78.61% ⭐ 2.93% 👍
rfpye/utils.py 74.60% 🙂 80.05% ⭐ 5.45% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
rfpye/utils.py recursive_walk 8 ⭐ 86 🙂 11 😞 61.23% 🙂 Extract out complex expressions
rfpye/parser.py CrfsGPS.__repr__ 0 ⭐ 30 ⭐ 12 😞 76.11% ⭐ Extract out complex expressions
rfpye/parser.py CrfsSpectrum.__str__ 0 ⭐ 23 ⭐ 10 😞 80.90% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@ronaldokun ronaldokun merged commit 9ecfde0 into master Oct 26, 2021
@ronaldokun ronaldokun deleted the new_blocks branch October 26, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant