Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PySlice_GetIndicesEx is deprecated #506

Closed
ronaldoussoren opened this issue Nov 6, 2022 · 1 comment
Closed

PySlice_GetIndicesEx is deprecated #506

ronaldoussoren opened this issue Nov 6, 2022 · 1 comment
Milestone
Internals Cleanup

Comments

@ronaldoussoren
Copy link
Owner

From the Python documentation:

Changed in version 3.6.1: If Py_LIMITED_API is not set or set to the value between 0x03050400 and 0x03060000 (not including) or 0x03060100 or higher PySlice_GetIndicesEx() is implemented as a macro using PySlice_Unpack() and PySlice_AdjustIndices(). Arguments start, stop and step are evaluated more than once.

Deprecated since version 3.6.1: If Py_LIMITED_API is set to the value less than 0x03050400 or between 0x03060000 and 0x03060100 (not including) PySlice_GetIndicesEx() is a deprecated function.

This API is used in struct-wrapper.m, replace by a similar expansion as mentioned in the first bit of the quote.
@ronaldoussoren ronaldoussoren added this to the Internals Cleanup milestone Nov 6, 2022
ronaldoussoren added a commit that referenced this issue Dec 16, 2022
@ronaldoussoren
Stop using PySlice_GetIndicesEx
4b37308 
This function was deprecated in Python 3.6.

Fixes #506
@ronaldoussoren
Copy link
Owner Author

Will be fixed once I merge the selector-transform branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Internals Cleanup
Development

No branches or pull requests
1 participant
@ronaldoussoren