Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoted text creates unpexpected output #12

Closed
jvandijk opened this issue Aug 24, 2014 · 3 comments
Closed

Quoted text creates unpexpected output #12

jvandijk opened this issue Aug 24, 2014 · 3 comments

Comments

@jvandijk
Copy link
Contributor

Hey @RonaldTreur,

I hope you don't mind I keep sending in issues... I've found another one.
The following scss snippet:

Window {
    background-color: "#2e2d2b";
    backButtonTitle: "";
    @media ios {
        navBarHidden: true;
        top: -20;
        barColor: $backgroundColor;
        barImage: '/images/transparent.png';
        hideShadow: true;
    }
}

Generates this TSS output:

"Window": {
        backgroundColor: "#2e2d2b",
        backButtonTitle: "\"\""
},
"Window[platform=ios]": {
        navBarHidden: true,
        top: -20,
        barColor: "#8cc63f",
        barImage: "/images/\"transparent.png\"",
        hideShadow: true
}

See the quoting on the barImage and backButtonTitle properties. Those references will fail to work.

@RonaldTreur
Copy link
Owner

Do I mind? I love it! Please keep them coming mate. It's due to guys (and girls) like you, STSS is where it is today!

That said.. I'll look into this! This is a tougher nut to crack.

@RonaldTreur
Copy link
Owner

Ok, fixed! The "." in the filename was what led the parser astray. Solved, and empty strings are supported now as well!

@jvandijk
Copy link
Contributor Author

Confirmed! That removes a couple of Alloy.Globals workarounds...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants