Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chinese link #6

Merged
merged 2 commits into from
Jun 8, 2018
Merged

Add chinese link #6

merged 2 commits into from
Jun 8, 2018

Conversation

chinanf-boy
Copy link
Contributor

Is link to My repo ??
or translate folder

Is link to My repo ??
or translate folder
@ronami
Copy link
Owner

ronami commented Jun 3, 2018

Hey @chinanf-boy, thank you! 🏆

Adding a link to your repo would be great, just a few small requests:

Thanks a lot for your contribution and effort :)

@chinanf-boy
Copy link
Contributor Author

new UI


Translations


My repo

https://github.com/chinanf-boy/minipack-explain

@ronami
Copy link
Owner

ronami commented Jun 5, 2018

Looks great :)

I think it’s important to also have the other missing files (LICENSE, .eslintrc) and a note somewhere explaining on the main README.md that this is a translation, with a link back to this repository.

If it’s not too much work, please fork this repository so all files and commits are retained and then add the translations on top of it.

Thank you 🙏

@chinanf-boy
Copy link
Contributor Author

@ronami

https://github.com/chinanf-boy/minipack-explain


这是一篇 翻译{Translations}

github source


@ronami ronami self-requested a review June 8, 2018 12:32
Copy link
Owner

@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for the translation!

@ronami ronami merged commit 6227a5e into ronami:master Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants