Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel 5 wrapper repository to readme #102

Conversation

pixelpeter
Copy link

Add Laravel 5 wrapper repository to the readme

@soullivaneuh
Copy link
Contributor

soullivaneuh commented May 22, 2016

Nice!

Maybe you could also add your package under the suggest section:

"suggest": {

@pixelpeter
Copy link
Author

Done ;-)

@soullivaneuh
Copy link
Contributor

@ronanguilloux LGTM

@ronanguilloux
Copy link
Owner

@pixelpeter Sorry, I didn't mind your PR while adding your repo to the README.
Feel free to rebase on master and then I'll add your composer suggestion.

Cheers!

@pixelpeter pixelpeter force-pushed the add-laravel-wrapper-to-readme branch from 4bf9a84 to df84e4a Compare May 29, 2016 09:59
@pixelpeter
Copy link
Author

@ronanguilloux Done the rebase. Please check if everything is OK.

@ronanguilloux
Copy link
Owner

Ouch, you didn't rebase on master, so you're now removing some recent changes. This PR cannot be merged.
Never mind, I'll add the composer.jon line by myself.
Thanks for that suggestion.

@pixelpeter
Copy link
Author

@ronanguilloux
Sorry, for that. This was my first rebase of a fork and I did it like it's described in several tutorials

git checkout add-laravel-wrapper-to-readme
git remote add upstream https://github.com/ronanguilloux/IsoCodes.git
git fetch upstream
git rebase upstream/master
git push origin add-laravel-wrapper-to-readme --force

MaximeLC2 pushed a commit to Vigicorp/IsoCodes that referenced this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants