-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #134 #136
Fixed #134 #136
Conversation
Hello, there is an issue. The SIRET 35600000000048 is a valid SIRET number. I see everywhere that the %5 is the new algorithm for La Poste. I didn't find any explanation about this. |
Simply because it is compliant with Luhn formula ;) |
Ok, so we must first check for the Luhn and then for La Poste Siret :) |
Guys, I prepared a fix for that remaining PR code review, taking into account the test case @PastisD raised: So @Geolim4 If you're too busy no worries, I'll commit mine by the end of the week. But if you still want to achieve this one within these next days, be my guest, I'll wait till next week-end Side note about the |
Added support for French mail company "La Poste" to SIRE(T|N) validators