Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a useless computation of the string length #21

Merged
merged 1 commit into from
May 2, 2015
Merged

Remove a useless computation of the string length #21

merged 1 commit into from
May 2, 2015

Conversation

stof
Copy link
Contributor

@stof stof commented Apr 29, 2015

We already know that the string length is equal to $length because of the previous check

@soullivaneuh
Copy link
Contributor

👍

@ronanguilloux
Copy link
Owner

#22 should fix the PHPUnit related issue in Travis:
May I ask you to fetch upstream (#22 was merged) first, then retry a commit+push?

@soullivaneuh
Copy link
Contributor

@stof please wait #23 to be merged.

@ronanguilloux
Copy link
Owner

#23 merged.

@ronanguilloux ronanguilloux added this to the 1.1.5 milestone Apr 30, 2015
ronanguilloux added a commit that referenced this pull request May 2, 2015
@ronanguilloux
Merge pull request #21 from stof/patch-1
c4e5a6b 
Remove a useless computation of the string length
@ronanguilloux ronanguilloux merged commit c4e5a6b into ronanguilloux:master May 2, 2015
@ronanguilloux
Copy link
Owner

Thanks.

@stof stof deleted the patch-1 branch May 4, 2015 13:56
MaximeLC2 pushed a commit to Vigicorp/IsoCodes that referenced this pull request Aug 25, 2020
@soullivaneuh
Merge pull request ronanguilloux#21 from Soullivaneuh/isbn-10-13
09f9e20 
Isbn 10 13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.1.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stof @soullivaneuh @ronanguilloux