Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add permissions field to binding #175

Merged
merged 1 commit into from
Apr 21, 2023
Merged

fix: add permissions field to binding #175

merged 1 commit into from
Apr 21, 2023

Conversation

GiovannaMonti
Copy link
Contributor

@GiovannaMonti GiovannaMonti commented Apr 21, 2023 •
edited
Loading

Right now when we create a binding and we pass permissions in the request body, they are ignored when the binding is created

@github-actions
Copy link

Pull Request Test Coverage Report for Build 4766057419

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 74.652%
Totals Coverage Status
Change from base Build 4744581045: 0.01%
Covered Lines: 1446
Relevant Lines: 1937
💛 - Coveralls

@fredmaggiowski fredmaggiowski added this pull request to the merge queue Apr 21, 2023
Merged via the queue into main with commit 9665cee Apr 21, 2023
10 checks passed
@fredmaggiowski fredmaggiowski added the bug Something isn't working label Apr 27, 2023
@fredmaggiowski fredmaggiowski deleted the fix/grant-api-permissions branch September 12, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredmaggiowski fredmaggiowski fredmaggiowski approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GiovannaMonti @fredmaggiowski