Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare URLs for Sprockets Asset Pipeline #17

Merged
merged 1 commit into from
Nov 10, 2015
Merged

Conversation

seanpdoyle
Copy link
Collaborator

Initial steps toward closing thoughtbot/ember-cli-rails#30.

  • Generate Rails manifest.json when building from Rails.
  • Prepend Sprockets path to EmberCLI assets.
  • Default fingerprinting to no generate MD5 hash when building in
    development.

@seanpdoyle seanpdoyle force-pushed the sd-generate-manifest branch 2 times, most recently from 728fc51 to 67f7dc5 Compare November 8, 2015 00:41
seanpdoyle added a commit to thoughtbot/ember-cli-rails that referenced this pull request Nov 8, 2015
Closes [#30].

Depends on [rondale-sc/ember-cli-rails-addon][#17].

* Symlink `dist/` directly to Asset Pipeline
* Merge EmberCLI-generated `manifest.json` into Sprocket's
* `manifest.json`. Since we now defer to EmberCLI, we no longer need to
  manually resolve asset URLs.
* Deletes `EmberCli::AssetResolver`
* Improve `bin/setup`, resolve errors.

[#30]: #30
[#17]: rondale-sc/ember-cli-rails-addon#17
seanpdoyle added a commit to thoughtbot/ember-cli-rails that referenced this pull request Nov 8, 2015
Closes [#30].

Depends on [rondale-sc/ember-cli-rails-addon#17][#17].

* Symlink `dist/` directly to Asset Pipeline
* Merge EmberCLI-generated `manifest.json` into Sprocket's
* `manifest.json`. Since we now defer to EmberCLI, we no longer need to
  manually resolve asset URLs.
* Deletes `EmberCli::AssetResolver`
* Improve `bin/setup`, resolve errors.

[#30]: #30
[#17]: rondale-sc/ember-cli-rails-addon#17
seanpdoyle added a commit to thoughtbot/ember-cli-rails that referenced this pull request Nov 8, 2015
Closes [#30].

Depends on [rondale-sc/ember-cli-rails-addon#17][#17].

* Symlink `dist/` directly to Asset Pipeline
* Deletes `EmberCli::AssetResolver`
* Improve `bin/setup`, resolve errors.

[#30]: #30
[#17]: rondale-sc/ember-cli-rails-addon#17
@seanpdoyle seanpdoyle changed the title Generate Rails manifest.json Prepare URLs for Sprockets Asset Pipeline Nov 8, 2015
seanpdoyle added a commit to thoughtbot/ember-cli-rails that referenced this pull request Nov 8, 2015
Closes [#30].

Depends on [rondale-sc/ember-cli-rails-addon#17][#17].

* Symlink `dist/` directly to Asset Pipeline
* Deletes `EmberCli::AssetResolver`
* Improve `bin/setup`, resolve errors.

[#30]: #30
[#17]: rondale-sc/ember-cli-rails-addon#17
seanpdoyle added a commit to thoughtbot/ember-cli-rails that referenced this pull request Nov 8, 2015
Closes [#30].

Depends on [rondale-sc/ember-cli-rails-addon#17][#17].

* Symlink `dist/` directly to Asset Pipeline
* Deletes `EmberCli::AssetResolver`
* Improve `bin/setup`, resolve errors.

[#30]: #30
[#17]: rondale-sc/ember-cli-rails-addon#17
@seanpdoyle seanpdoyle force-pushed the sd-generate-manifest branch 10 times, most recently from 2a3f513 to 57f32c1 Compare November 10, 2015 02:23
Initial steps toward closing [thoughtbot/ember-cli-rails#30][#30].

* Prepend Sprockets path to EmberCLI assets.
* Default fingerprinting to no generate `MD5` hash when building in
  `development`.

[#30]: thoughtbot/ember-cli-rails#30
@seanpdoyle seanpdoyle merged commit 941350f into master Nov 10, 2015
seanpdoyle added a commit to thoughtbot/ember-cli-rails that referenced this pull request Nov 10, 2015
Closes [#30].

Depends on [rondale-sc/ember-cli-rails-addon#17][#17].

* Symlink `dist/` directly to Asset Pipeline
* Deletes `EmberCli::AssetResolver`
* Improve `bin/setup`, resolve errors.

[#30]: #30
[#17]: rondale-sc/ember-cli-rails-addon#17
seanpdoyle added a commit to thoughtbot/ember-cli-rails that referenced this pull request Nov 10, 2015
Closes [#30].

Depends on [rondale-sc/ember-cli-rails-addon#17][#17].

* Symlink `dist/` directly to Asset Pipeline
* Deletes `EmberCli::AssetResolver`
* Improve `bin/setup`, resolve errors.

[#30]: #30
[#17]: rondale-sc/ember-cli-rails-addon#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant