-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare URLs for Sprockets Asset Pipeline #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
728fc51
to
67f7dc5
Compare
seanpdoyle
added a commit
to thoughtbot/ember-cli-rails
that referenced
this pull request
Nov 8, 2015
Closes [#30]. Depends on [rondale-sc/ember-cli-rails-addon][#17]. * Symlink `dist/` directly to Asset Pipeline * Merge EmberCLI-generated `manifest.json` into Sprocket's * `manifest.json`. Since we now defer to EmberCLI, we no longer need to manually resolve asset URLs. * Deletes `EmberCli::AssetResolver` * Improve `bin/setup`, resolve errors. [#30]: #30 [#17]: rondale-sc/ember-cli-rails-addon#17
seanpdoyle
added a commit
to thoughtbot/ember-cli-rails
that referenced
this pull request
Nov 8, 2015
Closes [#30]. Depends on [rondale-sc/ember-cli-rails-addon#17][#17]. * Symlink `dist/` directly to Asset Pipeline * Merge EmberCLI-generated `manifest.json` into Sprocket's * `manifest.json`. Since we now defer to EmberCLI, we no longer need to manually resolve asset URLs. * Deletes `EmberCli::AssetResolver` * Improve `bin/setup`, resolve errors. [#30]: #30 [#17]: rondale-sc/ember-cli-rails-addon#17
6fa63d2
to
78e01d0
Compare
seanpdoyle
added a commit
to thoughtbot/ember-cli-rails
that referenced
this pull request
Nov 8, 2015
Closes [#30]. Depends on [rondale-sc/ember-cli-rails-addon#17][#17]. * Symlink `dist/` directly to Asset Pipeline * Deletes `EmberCli::AssetResolver` * Improve `bin/setup`, resolve errors. [#30]: #30 [#17]: rondale-sc/ember-cli-rails-addon#17
manifest.json
seanpdoyle
added a commit
to thoughtbot/ember-cli-rails
that referenced
this pull request
Nov 8, 2015
Closes [#30]. Depends on [rondale-sc/ember-cli-rails-addon#17][#17]. * Symlink `dist/` directly to Asset Pipeline * Deletes `EmberCli::AssetResolver` * Improve `bin/setup`, resolve errors. [#30]: #30 [#17]: rondale-sc/ember-cli-rails-addon#17
78e01d0
to
b9a82a1
Compare
seanpdoyle
added a commit
to thoughtbot/ember-cli-rails
that referenced
this pull request
Nov 8, 2015
Closes [#30]. Depends on [rondale-sc/ember-cli-rails-addon#17][#17]. * Symlink `dist/` directly to Asset Pipeline * Deletes `EmberCli::AssetResolver` * Improve `bin/setup`, resolve errors. [#30]: #30 [#17]: rondale-sc/ember-cli-rails-addon#17
2a3f513
to
57f32c1
Compare
Initial steps toward closing [thoughtbot/ember-cli-rails#30][#30]. * Prepend Sprockets path to EmberCLI assets. * Default fingerprinting to no generate `MD5` hash when building in `development`. [#30]: thoughtbot/ember-cli-rails#30
57f32c1
to
941350f
Compare
seanpdoyle
added a commit
to thoughtbot/ember-cli-rails
that referenced
this pull request
Nov 10, 2015
Closes [#30]. Depends on [rondale-sc/ember-cli-rails-addon#17][#17]. * Symlink `dist/` directly to Asset Pipeline * Deletes `EmberCli::AssetResolver` * Improve `bin/setup`, resolve errors. [#30]: #30 [#17]: rondale-sc/ember-cli-rails-addon#17
seanpdoyle
added a commit
to thoughtbot/ember-cli-rails
that referenced
this pull request
Nov 10, 2015
Closes [#30]. Depends on [rondale-sc/ember-cli-rails-addon#17][#17]. * Symlink `dist/` directly to Asset Pipeline * Deletes `EmberCli::AssetResolver` * Improve `bin/setup`, resolve errors. [#30]: #30 [#17]: rondale-sc/ember-cli-rails-addon#17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial steps toward closing thoughtbot/ember-cli-rails#30.
manifest.json
when building from Rails.MD5
hash when building indevelopment
.