Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing custom fonts? #110

Closed
jmoral4 opened this issue Jun 25, 2019 · 3 comments
Closed

Missing custom fonts? #110

jmoral4 opened this issue Jun 25, 2019 · 3 comments

Comments

@jmoral4
Copy link

jmoral4 commented Jun 25, 2019

Building (latest) is a bit of a pain. The custom fonts generate build errors and who wants to download random fonts from random websites? If you use custom fonts, those should be bundled into the product or the fonts used should be common across all supported platforms.

Otherwise, the library turns from "drop in, easy to use" to a pain to setup. Also wish there was a cleaner way to handle the DataType refs. All of that is bound to through new people for a loop.

@RonenNess
Copy link
Owner

Hi @jmoral4,
The fonts are already included, please see here:

https://github.com/RonenNess/GeonBit.UI/blob/master/README.md#via-nuget

However I can't install them automatically via nuget, same with the DataTypes reference.

I can technically add manual scripts and try to install fonts with elevated privileges and change the project itself to add the reference, but I don't want to do it because it feels intrusive and not easily reversible. So I prefer to have the users do those steps so they will at least know what's going on and to eliminate any chance that my package my accidentally ruin their project file.

I agree it's not optimal but unless nuget add built-in support in these advanced installation steps I don't think I'll change that.

Thanks for the feedback!

@mxmissile
Copy link

I cant find these fonts to install, where exactly are they located? In the packages folder? Or the project Content folder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants