Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply lines become misleading #4

Closed
Freeplayg opened this issue Mar 26, 2023 · 6 comments
Closed

Reply lines become misleading #4

Freeplayg opened this issue Mar 26, 2023 · 6 comments
Labels
help wanted Extra attention is needed wontfix This will not be worked on

Comments

@Freeplayg
Copy link
Contributor

The lines are usually supposed to show that a reply is a direct reply to the one above, however this reply below isn't responding to the one above it, it's replying to another post above the rest.
image

Although it does look more like Twitter, I feel it's probably best to remove them for now because Mastodon's way of handling replies don't work for it

@ronilaukkarinen
Copy link
Owner

Yes, it's intentional.

Although it does look more like Twitter, I feel it's probably best to remove them for now because Mastodon's way of handling replies don't work for it

Yeah it's made to look like Twitter, but the lines have no actual relation to the actual replies because there's no helpers for that (Mastodon doesn't support threading at the moment).

They just feel so "empty" without any indication or relation to each other:

Screen-Shot-2023-03-27-15-50-32 94

I understand it's the same way than in the default UI like this, but I still kinda like it has "something".

I'm not going to instantly remove the reply lines, but will think about it. I'm open to ideas here. Faded or dashed line or something? 🤔

@jarilehtinen
Copy link

Horizontal lines between the posts? Vertical lines indeed create an illusion of related posts.

@ronilaukkarinen
Copy link
Owner

ronilaukkarinen commented Apr 1, 2023

The current structure allows only for them all to be linked or none of them. In my opinion neither is good. Some day I'd like it to be like this:

Screenshot_20230402-002137_Chrome-01

I'll try to get helper classes modified to my instance first and then make styles for them. After this I'll revert the default to non-lined version. I hope Mastodon core will have some helper classes in the DOM in the future. Right now they are all on the same level.

@ronilaukkarinen
Copy link
Owner

Just implemented a Mastodon back end code to get helper divs and classes and achieved this:

image

If there is no such classes, we just show borders without any lines:

image

Going to push it to next rc version.

@ronilaukkarinen
Copy link
Owner

ronilaukkarinen commented Apr 2, 2023

Changed the structure to be more reliable, see the commits.

@ronilaukkarinen
Copy link
Owner

I'm going to close this for now as the fallback is implemented by default (with lines) and adding the threading support is well documented. We'll see what happens in the Mastodon core in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants