Code quality check added

ronisaha · Jan 8, 2015 · b38f4a8 · b38f4a8
1 parent cd9201e
commit b38f4a8
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 17 deletions.
diff --git a/README.md b/README.md
@@ -3,6 +3,8 @@ Easy Bangla Date
 [![Build Status](https://travis-ci.org/ronisaha/easy-bangla-date.png?branch=master)](https://travis-ci.org/ronisaha/easy-bangla-date)
 [![HHVM Status](http://hhvm.h4cc.de/badge/ronisaha/easy-bangla-date.svg)](http://hhvm.h4cc.de/package/ronisaha/easy-bangla-date)
 [![Coverage Status](https://coveralls.io/repos/ronisaha/easy-bangla-date/badge.png)](https://coveralls.io/r/ronisaha/easy-bangla-date)
+[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/ronisaha/easy-bangla-date/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/ronisaha/easy-bangla-date/?branch=master)
+[![Latest Stable Version](https://poser.pugx.org/ronisaha/easy-bangla-date/v/stable.png)](https://packagist.org/packages/ronisaha/easy-bangla-date)
 [![Total Downloads](https://poser.pugx.org/ronisaha/easy-bangla-date/downloads.png)](https://packagist.org/packages/ronisaha/easy-bangla-date)
 
 Utility Library For Bangla Date and Time. The conversion logic got from https://github.com/mhmithu/bangla-date-and-time

diff --git a/Tools/Converter.php b/Tools/Converter.php
@@ -71,7 +71,7 @@ private static function getBengaliDateAndMonth($month, $day, $hour, $morning, $i
     private static function convertDatesOfJanuaryOrApril($day, $hour, $morning, $bnMonth)
     {
         if ($day >= 1 && $day <= 13) {
-            return array(self::getNextDayIfNot($day + 16, $hour < $morning), $bnMonth);
+            return self::getDateForLastMonth($day, $hour, $morning, $bnMonth, 16);
         }
 
         if ($day == 14 && $hour < $morning) {
@@ -121,17 +121,17 @@ private static function getNextMonth($month)
      */
     private static function convertDatesOfFebruary($day, $hour, $morning)
     {
-        $month = 10;
+        $bnMonth = 10;
 
         if ($day >= 1 && $day <= 12) {
-            return array(self::getNextDayIfNot($day + 17, $hour < $morning), $month);
+            return self::getDateForLastMonth($day, $hour, $morning, $bnMonth, 17);
         }
 
         if ($day == 13 && $hour < $morning) {
-            return array($day + 17, $month);
+            return array($day + 17, $bnMonth);
         }
 
-        return self::getDateForNextMonth($day, $hour, $morning, $month, 13);
+        return self::getDateForNextMonth($day, $hour, $morning, $bnMonth, 13);
     }
 
     /**
@@ -143,17 +143,17 @@ private static function convertDatesOfFebruary($day, $hour, $morning)
      */
     private static function convertDatesOfMarch($day, $hour, $morning, $isLeapYear)
     {
-        $month = 11;
+        $bnMonth = 11;
 
         if ($day >= 1 && $day <= 14) {
-            return array(self::getNextDayIfNot($day + self::getNextDayIfNot(15, $hour < $morning), !$isLeapYear), $month);
+            return array(self::getNextDayIfNot($day + self::getNextDayIfNot(15, $hour < $morning), !$isLeapYear), $bnMonth);
         }
 
         if ($day == 15 && $hour < $morning) {
-            return array(self::getNextDayIfNot($day + 15, !$isLeapYear), $month);
+            return array(self::getNextDayIfNot($day + 15, !$isLeapYear), $bnMonth);
         }
 
-        return self::getDateForNextMonth($day, $hour, $morning, $month, 15);
+        return self::getDateForNextMonth($day, $hour, $morning, $bnMonth, 15);
     }
 
     /**
@@ -166,7 +166,7 @@ private static function convertDatesOfMarch($day, $hour, $morning, $isLeapYear)
     private static function convertDatesOfMayOrJune($day, $hour, $morning, $bnMonth)
     {
         if ($day >= 1 && $day <= 14) {
-            return array(self::getNextDayIfNot($day + 16, $hour < $morning), $bnMonth);
+            return self::getDateForLastMonth($day, $hour, $morning, $bnMonth, 16);
         }
 
         if ($day == 15 && $hour < $morning) {
@@ -186,7 +186,7 @@ private static function convertDatesOfMayOrJune($day, $hour, $morning, $bnMonth)
     private static function convertDatesOfJulyOrAugustOrSeptember($day, $hour, $morning, $bnMonth)
     {
         if ($day >= 1 && $day <= 15) {
-            return array(self::getNextDayIfNot($day + 15, $hour < $morning), $bnMonth);
+            return self::getDateForLastMonth($day, $hour, $morning, $bnMonth, 15);
         }
 
         if ($day == 16 && $hour < $morning) {
@@ -198,17 +198,17 @@ private static function convertDatesOfJulyOrAugustOrSeptember($day, $hour, $morn
 
     private static function convertDatesOfOctober($day, $hour, $morning)
     {
-        $month = 6;
+        $bnMonth = 6;
 
         if ($day >= 1 && $day <= 15) {
-            return array(self::getNextDayIfNot($day + 14, $hour < $morning), $month);
+            return self::getDateForLastMonth($day, $hour, $morning, $bnMonth, 14);
         }
 
         if ($day == 16 && $hour < $morning) {
-            return array($day + 14, $month);
+            return array($day + 14, $bnMonth);
         }
 
-        return self::getDateForNextMonth($day, $hour, $morning, $month, 16);
+        return self::getDateForNextMonth($day, $hour, $morning, $bnMonth, 16);
     }
 
     /**
@@ -221,7 +221,7 @@ private static function convertDatesOfOctober($day, $hour, $morning)
     private static function convertDatesOfNovemberOrDecember($day, $hour, $morning, $bnMonth)
     {
         if ($day >= 1 && $day <= 14) {
-            return array(self::getNextDayIfNot($day + 15, $hour < $morning), $bnMonth);
+            return self::getDateForLastMonth($day, $hour, $morning, $bnMonth, 15);
         }
 
         if ($day == 15 && $hour < $morning) {
@@ -261,4 +261,17 @@ private static function isBeforeNewYear($enMonth, $day, $hour, $morning)
     {
         return $enMonth < 4 || ($enMonth == 4 && (($day < 14) || ($day == 14 && $hour < $morning)));
     }
+
+    /**
+     * @param $day
+     * @param $hour
+     * @param $morning
+     * @param $bnMonth
+     * @param $offset
+     * @return array
+     */
+    private static function getDateForLastMonth($day, $hour, $morning, $bnMonth, $offset)
+    {
+        return array(self::getNextDayIfNot($day + $offset, $hour < $morning), $bnMonth);
+    }
 }
diff --git a/Types/BnDateTime.php b/Types/BnDateTime.php
@@ -54,7 +54,7 @@ public function format($format)
     /**
      * @TODO: Implement get day in month
      */
-    private function getDayInMonth($month)
+    private function getDayInMonth()
     {
         return "";
     }