🐛 Do not remove quotes if cell is AbstractString

ronisbr · Sep 30, 2020 · 6d6c6e1 · 6d6c6e1
1 parent 2c260d0
commit 6d6c6e1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/backends/text/cell_parse.jl b/src/backends/text/cell_parse.jl
@@ -95,7 +95,7 @@ end
                                   renderer::Union{Val{:print}, Val{:show}} = Val(:print),
                                   kwargs...)
 
-    isstring = cell_data_type <: String
+    isstring = cell_data_type <: AbstractString
 
     if cell_first_line_only
         cell_vstr  = [first(_str_line_breaks(cell,

diff --git a/test/text_backend.jl b/test/text_backend.jl
@@ -2392,7 +2392,7 @@ end
     # Test the behavior if a formatter returns a string but the original data is
     # not a string. In this case, the renderer `show` must not add surrounding
     # quotes.
-    matrix = ['1' "2" 3]
+    matrix = ['1' "2" 3 s"123"]
 
     f = (v,i,j)->begin
         if j == 1
@@ -2401,15 +2401,17 @@ end
             return "😁😁"
         elseif j == 3
             return 'a'
+        else
+            return v
         end
     end
 
     expected = """
-┌────────┬────────┬────────┐
-│ Col. 1 │ Col. 2 │ Col. 3 │
-├────────┼────────┼────────┤
-│ 😀😀😀 │ "😁😁" │    'a' │
-└────────┴────────┴────────┘
+┌────────┬────────┬────────┬────────┐
+│ Col. 1 │ Col. 2 │ Col. 3 │ Col. 4 │
+├────────┼────────┼────────┼────────┤
+│ 😀😀😀 │ "😁😁" │    'a' │ s"123" │
+└────────┴────────┴────────┴────────┘
 """
 
     result = pretty_table(String, matrix,