Detect annotations during expand super types step #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hejcz
changed the title
|
sounds good @hejcz |
|
While the signatures you proposed look nice would the code be similar in these two cases?
They seem to be quite different. |
|
you're right, let me look it through. |
ronmamo
added a commit
that referenced
this pull request
Oct 25, 2021
* fix npe on empty Resources store * ReflectionUtils.Methods to use getDeclaredMethods * add ReflectionUtils.Resources * add JdkTests * fragile/flaky * fix scanner index for deprecated scanners :( * deprecated scanners javadocs * JdkTests cleanup * Bump maven-javadoc-plugin from 3.1.1 to 3.3.1 (#352) * Detect annotations during expand super types step (#354) * Add subtypes to SubTypes store during expand super types step * Detect annotations during expandSuperType step Co-authored-by: Julian Rubin <julian.rubin@rtbhouse.com> * npe fix * ConfigurationBuilder.setParallel fluent * readme * arranged ReflectionsExpandSupertypesTest * Correct the wrong match (#334) * Correct the wrong matc * Fetch upstream Co-authored-by: ileler <ileler@qq.com> * arranged VfsTest * minors Co-authored-by: ronma <ronma@> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julian Rubin <rubin94@gmail.com> Co-authored-by: Julian Rubin <julian.rubin@rtbhouse.com> Co-authored-by: Kerwin Bryant <kerwin612@qq.com> Co-authored-by: ileler <ileler@qq.com>
|
merged into 0.10.2 thanks Julian @hejcz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it might be benecial to fill missing annotations when expanding supertypes. This step fills only SubTypes store leaving TypesAnnotated store untouched. In our project we have a huge classpath and want to limit scan phase as much as possible. We rely on getTypesAnnotatedWith though so we had our own fork just for this case.
Do you think it might become part of the library?