Skip to content

Commit

Permalink
fix: pass report stats option for simplified api
Browse files Browse the repository at this point in the history
  • Loading branch information
hiroshihorie committed Nov 27, 2023
1 parent 95db12f commit beda14d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
9 changes: 6 additions & 3 deletions Sources/LiveKit/Participant/LocalParticipant.swift
Original file line number Diff line number Diff line change
Expand Up @@ -506,10 +506,12 @@ public extension LocalParticipant {
} else if enabled {
// Try to create a new track
if source == .camera {
let localTrack = LocalVideoTrack.createCameraTrack(options: (captureOptions as? CameraCaptureOptions) ?? room._state.options.defaultCameraCaptureOptions)
let localTrack = LocalVideoTrack.createCameraTrack(options: (captureOptions as? CameraCaptureOptions) ?? room._state.options.defaultCameraCaptureOptions,
reportStatistics: room._state.options.reportRemoteTrackStatistics)
return try await publish(videoTrack: localTrack, publishOptions: publishOptions as? VideoPublishOptions)
} else if source == .microphone {
let localTrack = LocalAudioTrack.createTrack(options: (captureOptions as? AudioCaptureOptions) ?? room._state.options.defaultAudioCaptureOptions)
let localTrack = LocalAudioTrack.createTrack(options: (captureOptions as? AudioCaptureOptions) ?? room._state.options.defaultAudioCaptureOptions,
reportStatistics: room._state.options.reportRemoteTrackStatistics)
return try await publish(audioTrack: localTrack, publishOptions: publishOptions as? AudioPublishOptions)
} else if source == .screenShareVideo {
#if os(iOS)
Expand All @@ -533,7 +535,8 @@ public extension LocalParticipant {
if #available(macOS 12.3, *) {
let mainDisplay = try await MacOSScreenCapturer.mainDisplaySource()
let track = LocalVideoTrack.createMacOSScreenShareTrack(source: mainDisplay,
options: (captureOptions as? ScreenShareCaptureOptions) ?? self.room._state.options.defaultScreenShareCaptureOptions)
options: (captureOptions as? ScreenShareCaptureOptions) ?? self.room._state.options.defaultScreenShareCaptureOptions,
reportStatistics: room._state.options.reportRemoteTrackStatistics)
return try await publish(videoTrack: track, publishOptions: publishOptions as? VideoPublishOptions)
}
#endif
Expand Down
5 changes: 3 additions & 2 deletions Sources/LiveKit/Track/Local/LocalAudioTrack.swift
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ public class LocalAudioTrack: Track, LocalTrack, AudioTrack {
}

public static func createTrack(name: String = Track.microphoneName,
options: AudioCaptureOptions? = nil) -> LocalAudioTrack
options: AudioCaptureOptions? = nil,
reportStatistics: Bool = false) -> LocalAudioTrack
{
let options = options ?? AudioCaptureOptions()

Expand All @@ -57,7 +58,7 @@ public class LocalAudioTrack: Track, LocalTrack, AudioTrack {
return LocalAudioTrack(name: name,
source: .microphone,
track: rtcTrack,
reportStatistics: true)
reportStatistics: reportStatistics)
}

@discardableResult
Expand Down

0 comments on commit beda14d

Please sign in to comment.