Support node@12 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we get this merged? |
|
@ronomon Can you merge this please? |
|
This package seems all but abandoned. I guess people can use the built-in base64 functionality in Nodejs though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
Based on: bcoin-org/bcrypto#7 (comment)
Please note, I don't have experience with node-gyp bindings, just changed that and tested locally - everything seems to be working. But if there's anything more required, please let me know.
Also fixed following warnings in node@10:
btw. maybe we could set up a CI build for testing compatibility with future node versions?