New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uninitialized value warning at Simple.pm:475 #4
Comments
Hi Jason
The ABORT code was pulled by me, not written by me, so I'd better
investigate immediately.
…On 06/01/18 10:52, Jason Tibbitts wrote:
After my distro (Fedora 27) updated to versipon 1.32, my RT server
started spewing a whole lot of the following:
|[758] [Fri Jan 5 23:36:43 2018] [warning]: Use of uninitialized value
$ret in string eq at /usr/share/perl5/vendor_perl/Tree/Simple.pm line
475. (/usr/share/perl5/vendor_perl/Tree/Simple.pm:475) |
Previous to 67f3732
<67f3732>
Tree::Simple didn't care about the return value of the traversal
function but now it does. Seems to me the simplest fix is to test for
definedness before looking for the magic 'ABORT' value but it's been a
long time since I've done any real work in Perl. If, on the other hand,
it's mandatory that the traversal code return a defined value, I'll have
to dig and see if that's coming from the RT code or from some
intermediate module.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABT-BapBxjub7Bxadig2M_KjHYMPYEUks5tHrWsgaJpZM4RVFgp>.
--
Ron Savage - savage.net.au
|
V 1.33 is now on CPAN. Sigh: I should not have accepted the pull with/out/ some matching tests. |
Thanks for taking care of this so quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After my distro (Fedora 27) updated to versipon 1.32, my RT server started spewing a whole lot of the following:
Previous to 67f3732 Tree::Simple didn't care about the return value of the traversal function but now it does. Seems to me the simplest fix is to test for definedness before looking for the magic 'ABORT' value but it's been a long time since I've done any real work in Perl. If, on the other hand, it's mandatory that the traversal code return a defined value, I'll have to dig and see if that's coming from the RT code or from some intermediate module.
The text was updated successfully, but these errors were encountered: