Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninitialized value warning at Simple.pm:475 #4

Open
jasontibbitts opened this issue Jan 5, 2018 · 3 comments
Open

Uninitialized value warning at Simple.pm:475 #4

jasontibbitts opened this issue Jan 5, 2018 · 3 comments

Comments

@jasontibbitts
Copy link

After my distro (Fedora 27) updated to versipon 1.32, my RT server started spewing a whole lot of the following:

[758] [Fri Jan  5 23:36:43 2018] [warning]: Use of uninitialized value $ret in string eq at /usr/share/perl5/vendor_perl/Tree/Simple.pm line 475. (/usr/share/perl5/vendor_perl/Tree/Simple.pm:475)

Previous to 67f3732 Tree::Simple didn't care about the return value of the traversal function but now it does. Seems to me the simplest fix is to test for definedness before looking for the magic 'ABORT' value but it's been a long time since I've done any real work in Perl. If, on the other hand, it's mandatory that the traversal code return a defined value, I'll have to dig and see if that's coming from the RT code or from some intermediate module.

@ronsavage
Copy link
Owner

ronsavage commented Jan 6, 2018 via email

@ronsavage
Copy link
Owner

ronsavage commented Jan 6, 2018

V 1.33 is now on CPAN. Sigh: I should not have accepted the pull with/out/ some matching tests.

@jasontibbitts
Copy link
Author

Thanks for taking care of this so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants