Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug on firefox - words get multiple vectors #1

Closed
denik opened this issue Dec 6, 2015 · 4 comments
Closed

bug on firefox - words get multiple vectors #1

denik opened this issue Dec 6, 2015 · 4 comments

Comments

@denik
Copy link

denik commented Dec 6, 2015

Seems to works fine for me on Chrome, but on Firefox, it looks like this (Note George twice):

screen shot 2015-12-06 at 22 59 59

@denik
Copy link
Author

denik commented Dec 6, 2015

I noticed in the docs, it says there are known issues with FF. Feel free to close this if no plans to support FF.

@ronxin
Copy link
Owner

ronxin commented Dec 6, 2015

Yes... that is the very issue I observed in FF. Do you have any idea what is causing this? Might be an easy fix.

@denik
Copy link
Author

denik commented Dec 6, 2015

Perhaps in this line unique() does not do what the name implies?

https://github.com/ronxin/wevi/blob/master/js/toyw2v.js#L104

vocab = $.unique(vocab).sort()

See http://stackoverflow.com/a/8137873 which suggests sorting first and then calling unique().

ronxin added a commit that referenced this issue Dec 7, 2015
Merge branch 'gh-pages'
@ronxin
Copy link
Owner

ronxin commented Dec 7, 2015

@denik Thanks for catching this!

@ronxin ronxin closed this as completed Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants