-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invalid value for Integer(): "0600469" #478
Comments
@tushgup93 Thank you for reporting this issue. roo uses ruby considers the value to be octal format if it starts with 0
Can you attach a sample excel file reproducing the mentioned issue so that expected behavior could be determined? Please feel free to open a PR for this! |
so it basically have 4 columns:
Can we avoid roo to check for valid integer type or tell it to consider it as string by default? |
@tushgup93 I'm unable to reproduce this issue. The excel client (google spreadsheet, libre office) I used to generate the sample file either didn't accept leading zero to integer or changed the cell to use text format. And both of these scenarios work well with roo. Since I'm unable to create an excel file which reproduces this issue, I'll suggest you attach a sample excel file which reproduces this issue. |
that is what i mentioned, on importing the excel file, roo does not accept it , so how to direct the cell to treat it as text format? |
@tushgup93 I've fixed the issue on the master. In roo typecasting take place when the file is parsed, due to which currently you cannot access raw value before typecasting takes place. If you still want to access raw value you can use the following method: |
thanks @chopraanmol1 , can you also create a version with this commit ? I am using 2.7 |
@tushgup93 I'll update you on this issue once we make next release. |
@tushgup93 roo v2.8.0 is released |
thanks!
…On Fri, Jan 18, 2019 at 11:53 AM Anmol Chopra ***@***.***> wrote:
@tushgup93 <https://github.com/tushgup93> roo v2.8.0 is released
https://rubygems.org/gems/roo/versions/2.8.0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#478 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/Alpl2SB0V1oBR9SvNqyHvawpayPOKpoKks5vEWh5gaJpZM4ZnoEQ>
.
|
I have excel file some columns are like this. Order column format cells category is General. @file.first_row return invalid value for Integer(): ""
Ruby version: 3.0.6 |
Thanks for filing an issue. Following these instructions will help us solve your problem sooner.
Steps to reproduce
Upload any excel with value starting with "0" as mentioned above .
Issue
Describe the issue
Any value that contains numbers , roo considers it as a number but when it starts with "0", it does not treat it as string instead it throws the error invalid value for Integer()
System configuration
Roo version:
roo-2.7.1
Ruby version:
2.3.0
The text was updated successfully, but these errors were encountered: