Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby 2.4.0 deprecation warnings #356

Merged
merged 4 commits into from
Dec 28, 2016
Merged

Fix Ruby 2.4.0 deprecation warnings #356

merged 4 commits into from
Dec 28, 2016

Conversation

matthewrudy
Copy link
Contributor

Removes fixnum deprecations and assert_nil warnings when running the tests.

@coveralls
Copy link

coveralls commented Dec 27, 2016

Coverage Status

Coverage remained the same at 93.661% when pulling 11f55a4 on gogovan:ruby-2.4 into 0f67aa1 on roo-rb:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.661% when pulling 11f55a4 on gogovan:ruby-2.4 into 0f67aa1 on roo-rb:master.

@coveralls
Copy link

coveralls commented Dec 27, 2016

Coverage Status

Coverage remained the same at 93.661% when pulling 11f55a4 on gogovan:ruby-2.4 into 0f67aa1 on roo-rb:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.661% when pulling 11f55a4 on gogovan:ruby-2.4 into 0f67aa1 on roo-rb:master.

@coveralls
Copy link

coveralls commented Dec 27, 2016

Coverage Status

Coverage increased (+0.03%) to 93.687% when pulling cf7bb74 on gogovan:ruby-2.4 into 0f67aa1 on roo-rb:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 93.687% when pulling cf7bb74 on gogovan:ruby-2.4 into 0f67aa1 on roo-rb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 93.687% when pulling cf7bb74 on gogovan:ruby-2.4 into 0f67aa1 on roo-rb:master.

@matthewrudy matthewrudy changed the title Ruby 2.4 compatibility Fix Ruby 2.4.0 deprecation warnings Dec 27, 2016
@stevendaniels stevendaniels merged commit 26aebf0 into roo-rb:master Dec 28, 2016
@stevendaniels
Copy link
Contributor

@matthewrudy: Thanks for the PR.

jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Jan 8, 2017
## [2.7.1] 2017-01-03
### Fixed
- Fixed regression where a CSV's encoding was being ignored [372](roo-rb/roo#372)

## [2.7.0] 2016-12-31
### Fixed
- Added rack server for testing Roo's download capabilities [365](roo-rb/roo#365)
- Refactored tests into different formats [365](roo-rb/roo#365)
- Fixed OpenOffice for JRuby [362](roo-rb/roo#362)
- Added '0.000000' => '%.6f' number format [354](roo-rb/roo#354)
- Add additional formula cell types for to_csv [367][roo-rb/roo#367]

### Added
- Extracted formatters from Roo::Base#to_* methods [364](roo-rb/roo#364)

## [2.6.0] 2016-12-28
### Fixed
- Fixed error if sheet name starts with a slash [348](roo-rb/roo#348)
- Fixed loading to support files on ftp [355](roo-rb/roo#355)
- Fixed Ruby 2.4.0 deprecation warnings [356](roo-rb/roo#356)
- properly return date as string [359](roo-rb/roo#359)

### Added
- Cell values can be set in a CSV [350](roo-rb/roo#350)
- Raise an error Roo::Excelx::Extractor document is missing [358](roo-rb/roo#358)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants