Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #389 #to_csv: changed predefined arguments and add documentation #469

Merged
merged 5 commits into from
Mar 14, 2024
Merged

fixes #389 #to_csv: changed predefined arguments and add documentation #469

merged 5 commits into from
Mar 14, 2024

Conversation

Mifrill
Copy link
Contributor

@Mifrill Mifrill commented Oct 17, 2018 •
edited
Loading

fixes issue #389

in detail:

  • changed predefined argument for method #to_csv to be convenient to use
  • added documentation for method #to_csv into readme

@Mifrill Mifrill changed the title fixes #389 #to_csv changed predefined arguments and add documentation fixes #389 #to_csv: changed predefined argument and add documentation Oct 17, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.085% when pulling bcadde3 on Mifrill:issue_389 into 8f65109 on roo-rb:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.085% when pulling bcadde3 on Mifrill:issue_389 into 8f65109 on roo-rb:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.085% when pulling bcadde3 on Mifrill:issue_389 into 8f65109 on roo-rb:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.085% when pulling bcadde3 on Mifrill:issue_389 into 8f65109 on roo-rb:master.

@coveralls
Copy link

coveralls commented Oct 17, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 94.421% when pulling f56f0c4 on Mifrill:issue_389 into 8f65109 on roo-rb:master.

@chopraanmol1 chopraanmol1 added this to the v3.0.0 milestone Oct 17, 2018
chopraanmol1
chopraanmol1 reviewed Oct 17, 2018
View reviewed changes
lib/roo/formatters/csv.rb Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@Mifrill Mifrill changed the title fixes #389 #to_csv: changed predefined argument and add documentation fixes #389 #to_csv: changed predefined arguments and add documentation Oct 17, 2018
@chopraanmol1 chopraanmol1 removed the request for review from tgturner December 21, 2018 09:00
@Mifrill
Copy link
Contributor Author

Mifrill commented Jul 28, 2020

Hello, @chopraanmol1! Could you take a look please, probably, need some updates on this? Thanks!

@Mifrill
Copy link
Contributor Author

Mifrill commented Jul 3, 2021

Hey @chopraanmol1 any updates here?

@Mifrill
Copy link
Contributor Author

Mifrill commented Aug 28, 2021

Hi, @simonoff please review 🙏

@Mifrill
Copy link
Contributor Author

Mifrill commented Sep 25, 2021

Hey @roo-rb members, any chance to have it merged?

@Mifrill
Copy link
Contributor Author

Mifrill commented Oct 9, 2021

@roo-rb ping

1 similar comment
@Mifrill
Copy link
Contributor Author

Mifrill commented Oct 20, 2021

@roo-rb ping

@Mifrill
Copy link
Contributor Author

Mifrill commented Dec 17, 2021

Hi @chopraanmol1, any chance to have it merged?

@Mifrill
Copy link
Contributor Author

Mifrill commented Mar 13, 2024

@roo-rb ping

@simonoff simonoff merged commit 3d24c11 into roo-rb:master Mar 14, 2024
@Mifrill Mifrill deleted the issue_389 branch March 14, 2024 12:00
@Mifrill
Copy link
Contributor Author

Mifrill commented Mar 14, 2024

@simonoff thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chopraanmol1 chopraanmol1 Awaiting requested review from chopraanmol1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mifrill @coveralls @chopraanmol1 @simonoff