Handle empty v element in column xml #542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt to fix #541.
Other Information
I'm open to suggestions on how the test is structured. I wanted to setup the tests in a way that made it easier to write future tests against various cell xml configurations. I use this gem at work with customer data so generating spreadsheets that reproduce issues is difficult due to having to scrub the data. I can easily unzip the spreadsheets to identify 'interesting' xml tags.
Ideally, I would have tested
cell_from_xmlto avoid dealing with arrays but I didn't want to change the visibility of that method for this bug fix.I would be interested in trying to restructure the SheetDoc class so it's easier to test some of core functionality of methods like
cell_from_xmlandcreate_cell_from_valuein the future. Is that something that would be of interest?