Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no implicit conversion error when datetime cell with hyperlink #556

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

muraaano
Copy link

@muraaano muraaano commented Mar 11, 2021

Summary

I found a bug and this PR to fix that.

Bug

  • If there is a cell as datetime and set to hyperlink, float value will be passed to Roo::Link.new. It cause type error from float to string.
  • How to produce bug:
    • execute below in irb
    xlsx = Roo::Spreadsheet.open(Rails.root.join("datetime_with_link.xlsx").to_s)
    xlsx.info
    
    TypeError (no implicit conversion of Float into String)
    
  • Environment:
    • ruby '2.6.6'
    • roo (2.8.2)

Other Information

I appreciate if this patch make gem better. Feel free to comment better implementation or anythingelse.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant