Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support String IOs for Excelx #573

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support String IOs for Excelx #573

wants to merge 5 commits into from

Conversation

wspurgin
Copy link

@wspurgin wspurgin commented Mar 4, 2022

Summary

Closes #360

Uses Zip::InputStream to get each entry (per RubyZip's README).

@wspurgin wspurgin marked this pull request as ready for review March 4, 2022 21:44
@wspurgin wspurgin changed the title Support string ios Support String IOs for Excelx Mar 4, 2022
@wspurgin
Copy link
Author

Hi 👋 @simonoff Any feedback on this fix?

@wspurgin
Handle non-fast, streamed compression
8dc508c 
e.g., if you export a xlsx from a Google Sheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using StringIO with Roo and XLSX fails.
1 participant
@wspurgin