Fix issue #593 #594
Open
Fix issue #593 #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshay-vashishtha
changed the title
akshay-vashishtha
changed the title
akshay-vashishtha
changed the title
akshay-vashishtha
changed the title
|
@akshay-vashishtha can you please add a suite of tests to validate the previous + new behaviour |
|
We're encountering this issue with some dates in XLSX files. In our case, the |
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution to the open issue is mentioned at #593 (comment). To address the problem when using an Excel file with a custom data type, the roo gem was unable to convert it into an integer or float. Therefore, I made changes to the create_date mechanism to identify such cases. Now, if we encounter an exact date instead of a number, the string will be parsed using the Date parser to ensure proper conversion.