Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bitseed validity test 3 #1706

Merged
merged 13 commits into from
May 27, 2024
Merged

feat: add bitseed validity test 3 #1706

merged 13 commits into from
May 27, 2024

Conversation

yubing744
Copy link
Collaborator

@yubing744 yubing744 commented May 18, 2024 •
edited

Summary

  1. Add unit test for is_valid_bitseed_mint method
  2. Add validity integration test for mint generator operation
  3. Add validity integration test for deploy operation

@vercel Vercel
Copy link

vercel bot commented May 18, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 2:51pm
rooch-rooch-portal-v1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 2:51pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 2:51pm

@yubing744 yubing744 changed the title feat: test is_valid_bitseed_mint feat: add bitseed validity test May 26, 2024
@yubing744 yubing744 changed the title feat: add bitseed validity test feat: add bitseed validity test 3 May 26, 2024
@yubing744 yubing744 marked this pull request as ready for review May 27, 2024 00:11
@yubing744
Copy link
Collaborator Author

@jolestar help review.

jolestar
jolestar approved these changes May 27, 2024
View reviewed changes
frameworks/moveos-stdlib/sources/address.move
@@ -61,6 +62,8 @@ module moveos_std::address {
};

let bytes = option::destroy_some(opt_bytes);

vector::reverse(&mut bytes); // Convert little endian encoding to big endian
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jolestar Tests have been added.

@jolestar jolestar merged commit 84c3677 into rooch-network:main May 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolestar jolestar jolestar approved these changes

@wow-sven wow-sven Awaiting requested review from wow-sven wow-sven is a code owner

@geometryolife geometryolife Awaiting requested review from geometryolife geometryolife is a code owner

@pause125 pause125 Awaiting requested review from pause125 pause125 is a code owner

@baichuan3 baichuan3 Awaiting requested review from baichuan3 baichuan3 is a code owner

@yourmoonlight yourmoonlight Awaiting requested review from yourmoonlight yourmoonlight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yubing744 @jolestar