-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the "0 degree meridian" issue in subsetting #35
Comments
@Zeitsperre why do we need a special implementation for this? I would suppose it works on xarray ... |
From our experience, it doesn't work right out of the box. You could try implementing a cleaner version without the handling but I think your results will be cut at the median line or the dateline, depending on the GCS of the netCDF data. |
We might be able to use the http://xarray.pydata.org/en/stable/generated/xarray.DataArray.roll.html Hence you could:
|
If I recall correctly, the reason why we didn't want to use the "roll" approach was because of the high processing load needed when processing large (>250GB) NetCDF files. It made much more sense to slice up the vector file to better suit the shape of the NetCDF than to change all the NetCDF data with roll. |
@agstephens I've been implementing this but haven't opened a PR yet as I've spotted a few issues with what I've done and I'm looking into them. Here are the changes I've made https://github.com/roocs/clisops/compare/cross_prime_meridian_fix The issues are:
|
Here's what I've come up with:
with
|
@ellesmith88: I've read through the code and it's looking great! Here are my responses to your three points:
Great stuff. |
Description
The
core.subset
module is missing the implementation for "crossing 0 degree meridian".clisops/clisops/core/subset.py
Line 114 in c493bc5
What I Did
The text was updated successfully, but these errors were encountered: