-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross prime meridian fix #117
Conversation
@huard @Zeitsperre This is our fix for coping with bounding box subsets where the requested longitude range does not overlap with the longitudes of the data itself. We believe there are no issues from your end because all the changes are dealt with in Please shout if you spot any problems with this. We plan to merge it tomorrow morning (UK time). |
Wow! This is a spotless fix. I'm glad to see that it doesn't roll the data on the Just a thought, but maybe it would be interesting to (in another PR) implement a fix on the |
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre Thanks for the review. Sounds like a good idea - I've opened an issue for it #119 |
Pull Request Checklist:
bumpversion minor
has been called on this branchAUTHORS.md
What kind of change does this PR introduce?:
Bug fix - where the subset request crosses the meridian but the longitudes are all positive, this implements a method to roll the dataset and reassign the coordinates to allow this subset to take place
Does this PR introduce a breaking change?:
I don't think so
Other information:
This also removes
pyyaml
from the requirements - I added this before the 5.4 of pyyaml version was released on conda to allow the docs to build. This version has now been released so this is no longer needed.