C3s mapping #108
Merged
C3s mapping #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Esgf test data fix
Test time invariant datasets
|
@Zeitsperre Would like to merge this today, just checking its ok by you |
Zeitsperre
approved these changes
Jan 20, 2021
| try: | ||
| url = "/".join((github_url, "raw", branch, md5name.as_posix())) | ||
| LOGGER.info("Fetching remote file md5: %s" % fullname.as_posix()) | ||
| LOGGER.info("Fetching remote file md5: %s" % md5name.as_posix()) |
There was a problem hiding this comment.
Nice catch, will need to fix this in other projects as well!
|
@ellesmith88 My changes are in and tests are passing locally. You can merge this as soon as the build clears or tomorrow morning! Thanks! EDIT: One final change to do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
bumpversion minorhas been called on this branchAUTHORS.mdWhat kind of change does this PR introduce?:
Small changes to allow datasets without a time dimension to pass through
Gets rid of submodule for mini-esgf-data
use
open_xr_datasetfromroocs_utils.xarray_utils.xarray_utilsinclisops.ops.subsetbut asexpand_wildcardsalways returns a list, this will not affectops.subsetDoes this PR introduce a breaking change?:
Using master branch of
roocs-utilstemporarily - changes in this PR will only work with this branchpyyaml>=5.3.*,<5.4in requirements so documents buildOther information: