Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed mention of git submodule in docs #112

Closed
wants to merge 2 commits into from

Conversation

agstephens
Copy link
Collaborator

Simple pull request to add to previous PR. Removes documentation about git submodules. No breaking issues.

@agstephens
Copy link
Collaborator Author

@ellesmith88 sorry, I missed this change in the original PR.

@ellesmith88
Copy link
Collaborator

@agstephens I was going to do this but I think the xclim-testdata submodule needs to be initiated for a few json files?

@agstephens
Copy link
Collaborator Author

@ellesmith88 : okay, I hadn't realised that. I'll ask Ouranos...

@Zeitsperre: do you still need the xclim test data as a submodule in the clisops git repo? I think we are ready to dissociate the mini-esgf-data submodule now.

@cehbrecht
Copy link
Collaborator

xclim test data is still used in the core:

from .._common import XCLIM_TESTS_DATA as TESTS_DATA

Can we replace the test files by our esgf dummy data or add the needed files to our own test-data repo xclim/...?

@Zeitsperre
Copy link
Collaborator

@agstephens I was going to do this but I think the xclim-testdata submodule needs to be initiated for a few json files?

If I follow correctly, the JSON files you mention are small enough that they can be gathered via the get_file method as well. For Xclim purposes, they were small enough that we simply loaded them into the library itself (https://github.com/Ouranosinc/xclim/tree/master/tests/testdata).

@ellesmith88
Copy link
Collaborator

Closed as already implemented in c3s_mapping branch

@ellesmith88 ellesmith88 deleted the esgf-test-data-fix branch January 15, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants