-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding AverageShape to daops #114
Conversation
@charlesgauthier-udm If the |
@charlesgauthier-udm tests are failing due to a new intake version. Do you like to add a restriction for intake within this PR? ... otherwise I will open a new PR to fix this. |
Since the failing tests are not related to the polygon subsetting, I would suggest opening another PR, but if you don't have the time I can limit intake to 0.7.0 in this PR which seems to be working. |
@charlesgauthier-udm I will open a new PR for the intake issue :) |
@charlesgauthier-udm tests are working again on master (PR #115) |
@charlesgauthier-udm I can merge if this PR is ok for you. |
Yes, all good thank you for your review. |
Pull Request Checklist:
AUTHORS.md
What kind of change does this PR introduce?:
This PR adds the Spatial Averager operator to daops allowing to perform an average over a specified region
Does this PR introduce a breaking change?:
Not to my knowledge
Other information:
As it is, the
shape
parameter required byAverageShape
is similar to the freq parameter ofAverageTime
in that it is only defined using the inputed argument. For the averqage across dimensions (Average
), thedims
parameter is defined as adimension_parameter
coming fromroocs_utils
. I was not sure if it was needed to add ashape_parameter
toroocs_utils
so I left it as is. If you feel like that would be preferable , please mention it in the PR and I'll add ashape_parameter
toroocs_utils
.