Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump to use go1.22 #291

Closed
wants to merge 1 commit into from
Closed

Conversation

chenrui333
Copy link

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Would be good to build with latest go

also relates to Homebrew/homebrew-core#171289

Signed-off-by: Rui Chen <rui@chenrui.dev>
@@ -1,6 +1,6 @@
module github.com/rook/kubectl-rook-ceph

go 1.21
go 1.22
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
go 1.22
go 1.22

The changes are good to me, only reason we have not done this yet is the rook/rook project still is on 1.21

@travisn should we plan to move to 1.22 in the main rook repo? I know the main repo is not directly related to this repo but just to be same page I put this questions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to wait a bit longer before requiring 1.22 in this or the rook repo, unless there is a need for the change. It's nice to support the two most recent minor versions of go.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that is fair. (I did not know the main repo coupling in here)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR anyway, we can take when we are ready to move to 1.22

@chenrui333 chenrui333 closed this May 11, 2024
@chenrui333 chenrui333 deleted the go-1.22 branch May 11, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants