Rook usage of Progressing condition type

[ron1]

According to this comment: rancher/wrangler#150 (comment), Rook may be using the Progressing condition type in a different way than the k8s Deployment resource uses it. This difference is currently causing the Rancher Fleet GitOps tool to report healthy CephCluster resources as erroneous (see issue #6977). What are your thoughts about this interpretation discrepancy regarding the Progressing condition type?

I believe the PR I submitted here: rancher/wrangler#150 will fix this specific compatibility issue between Rancher Fleet and Rook Ceph. Nevertheless, I think it is worthwhile to review Rook's usage of the Progressing condition type to ensure it is consistent with k8s.

[travisn]

So instead of setting progressing=false when the reconcile is completed, we should just remove the progressing condition. That seems like a simple enough change. I can see how progressing=false should be used as an error condition to indicate something is stuck/failed with the progress.

[ron1]

@travisn Your proposed solution makes sense to me. Do you want to create an issue to capture this work?

[travisn]

sounds good to me!

[ron1]

@travisn I went ahead and opened #7267 to capture this work.

[travisn]

Sounds good. Are you planning on working on that, or looking for help?

[ron1]

Am I correct that Rook currently does not remove conditions? If so, then any help you could offer is much appreciated.