Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr: disable the prometheus module by crds #11962

Closed
thenamehasbeentake opened this issue Mar 23, 2023 · 2 comments · Fixed by #11980
Closed

mgr: disable the prometheus module by crds #11962

thenamehasbeentake opened this issue Mar 23, 2023 · 2 comments · Fixed by #11980
Labels
Projects

Comments

@thenamehasbeentake
Copy link

Is this a bug report or feature request?

  • Feature Request

What should the feature do:
The prometheus module is always enabled. want to disable the prometheus module,

What is use case behind this feature:
The setting for monitoring.enabled: false and disable the module, true wiil enable

Enable prometheus module code by default is here:

startModuleConfiguration("prometheus", c.enablePrometheusModule)

Environment:

@parth-gr
Copy link
Member

parth-gr commented Mar 23, 2023

Here is the setting were you can adjust ti

@thenamehasbeentake
Copy link
Author

thenamehasbeentake commented Mar 23, 2023

My expression is pool. The issue want to config mgr module prometheus enable or disable. Maybe It is not associated with monitoring.enabled

When cluster is init, you can prometheus will be init too:

ceph mgr services
{
    "dashboard": "http://10.9.8.102:8080/",
    "prometheus": "http://10.9.8.102:9283/"
}

We can't disable prometheus via crds

It seems prometheus module could set disable here. Unfortunately, it has no effect after setting in my test.

I wish mgr prometheus module's port and enabled staus could be set by crds, just like DashboardSpec.

@travisn travisn added this to To do in v1.11 via automation Mar 23, 2023
@rkachach rkachach assigned rkachach and unassigned rkachach Mar 29, 2023
v1.11 automation moved this from To do to Done Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v1.11
Done
Development

Successfully merging a pull request may close this issue.

3 participants