Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr: disable the prometheus module by crds #11980

Merged
merged 2 commits into from
Mar 31, 2023
Merged

mgr: disable the prometheus module by crds #11980

merged 2 commits into from
Mar 31, 2023

Conversation

thenamehasbeentake
Copy link

@thenamehasbeentake thenamehasbeentake commented Mar 27, 2023 •
edited

Description of your changes:
support disable mgr prometheus module by crds
support configuration of disabled, server port and scrape interval for mgr prometheus module by crds

Which issue is resolved by this Pull Request:
Resolves #11962

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

travisn
travisn requested changes Mar 27, 2023
View reviewed changes
pkg/apis/ceph.rook.io/v1/types.go Outdated Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/mgr.go Outdated Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/mgr.go Outdated Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/mgr.go Show resolved Hide resolved
galexrt
galexrt requested changes Mar 28, 2023
View reviewed changes
pkg/apis/ceph.rook.io/v1/types.go Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/mgr.go Show resolved Hide resolved
rkachach
rkachach reviewed Mar 29, 2023
View reviewed changes
pkg/operator/ceph/cluster/mgr/mgr.go Outdated Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/mgr.go Outdated Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/mgr.go Show resolved Hide resolved
@thenamehasbeentake thenamehasbeentake force-pushed the support_disable_prometheus_module branch 2 times, most recently from 66fe967 to 57a96e7 Compare March 29, 2023 13:35
travisn
travisn requested changes Mar 29, 2023
View reviewed changes
Documentation/CRDs/Cluster/ceph-cluster-crd.md Outdated Show resolved Hide resolved
Documentation/CRDs/Cluster/ceph-cluster-crd.md Outdated Show resolved Hide resolved
pkg/operator/ceph/cluster/mgr/mgr_test.go Outdated Show resolved Hide resolved
docs: design doc for ceph cluster crds with monitoring
963f6d3 
Signed-off-by: xiaobaowen <xiaobaowen@deeproute.ai>
travisn
travisn requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a typo

pkg/operator/ceph/cluster/mgr/mgr.go Outdated Show resolved Hide resolved
mgr: disable the prometheus module by crds
e7254c2 
Signed-off-by: xiaobaowen <xiaobaowen@deeproute.ai>
@travisn travisn requested a review from galexrt March 31, 2023 14:10
galexrt
galexrt approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@galexrt galexrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travisn travisn merged commit 87e8364 into rook:master Mar 31, 2023
48 of 50 checks passed
@mergify mergify bot mentioned this pull request Mar 31, 2023
Merged
@travisn travisn mentioned this pull request Apr 3, 2023
Merged
7 tasks
travisn added a commit that referenced this pull request Apr 3, 2023
@travisn
Merge pull request #12014 from rook/mergify/bp/release-1.11/pr-11980
4f9b1e8 
mgr: disable the prometheus module by crds (backport #11980)
@benlsheets benlsheets mentioned this pull request Apr 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkachach rkachach rkachach left review comments

@travisn travisn travisn approved these changes

@galexrt galexrt galexrt approved these changes

Assignees
No one assigned
Labels
backport-release-1.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mgr: disable the prometheus module by crds
4 participants
@thenamehasbeentake @travisn @galexrt @rkachach