monitoring: set port for servicemonitor for ceph-exporter #12825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
requested changes
Aug 31, 2023
There was a problem hiding this comment.
A couple suggestions:
- Add a commit prefix as described in the development guide, such as
monitoring:. - The purpose of this change is to set the port name for the exporter, correct? Please describe the behavior change in the commit title or description. It's more important to say the behavior change in the commit message than to say what method it was in.
Thanks!
subhamkrai
previously requested changes
Sep 1, 2023
avanthakkar
approved these changes
Sep 1, 2023
ceph-exporter's ServiceMonitor and Service CRD contain different port name, which results in no metrics being collected by prometheus. this commit makes GetCephMonitor configurable, which we use to set consistent port names in ServiceMonitor and Service for ceph-exporter. Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
weirdwiz
force-pushed
the
service-monitor-port
branch
from
28b1609
to
708dd29
Compare
weirdwiz
changed the title
travisn
approved these changes
Sep 1, 2023
mergify bot
added a commit
that referenced
this pull request
Sep 1, 2023
monitoring: set port for servicemonitor for ceph-exporter (backport #12825)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ceph-exporter's ServiceMonitor and Service CRD contain different port
name, which results in no metrics being collected by prometheus.
this commit makes GetCephMonitor configurable, which we use to set
consistent port names in ServiceMonitor and Service for ceph-exporter.