Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket quota can't be updated #7146

Closed
tumido opened this issue Feb 3, 2021 · 3 comments · Fixed by #8514
Closed

Bucket quota can't be updated #7146

tumido opened this issue Feb 3, 2021 · 3 comments · Fixed by #8514
Assignees
Labels
bug ceph main ceph tag object-bucket-claims Object Bucket Claims (OBC)

Comments

@tumido
Copy link

tumido commented Feb 3, 2021

Is this a bug report or feature request?

  • Bug Report

Deviation from expected behavior:
When creating ObjectBucketClaim user can specify .spec.additionalConfig values like maxSize and maxObjects. This value is enforced as a quota on the bucket. However if user later decides to update the spec and increase the quota, this change doesn't trigger reconciliation. New quota is not propagated to ObjectBucket resource or to the Ceph back-end bucket.

Expected behavior:
Quota should be updated.

How to reproduce it (minimal and precise):

  1. CreateObjectBucketClaim with maxSize set to a value
  2. `oc patch obc/RESOURCE_NAME -p '{"spec": {"additionalConfig": {"maxSize": "different value"}}
  3. Compare ObjectBucketClaim and ObjectBucket and the actual quota. maxSize is changed only in ObjectBucketClaim

File(s) to submit:
n/a

Environment:

  • OS (e.g. from /etc/os-release): RHEL
  • Kernel (e.g. uname -a): 4.18
  • Cloud provider or hardware configuration: Openshift 4.5
  • Rook version (use rook version inside of a Rook Pod): 4.5-55.6dba87fd.release_4.5
  • Storage backend version (e.g. for ceph do ceph -v): ceph version 14.2.8-111.el8cp (2e6029d57bc594eceba4751373da6505028c2650) nautilus (stable)
  • Kubernetes version (use kubectl version): client v1.19.4, server v1.18.3
  • Kubernetes cluster type (e.g. Tectonic, GKE, OpenShift): Openshift
  • Storage backend status (e.g. for Ceph use ceph health in the Rook Ceph toolbox): HEALTH_OK
@thotz
Copy link
Contributor

thotz commented Feb 16, 2021

@tumido
This is issue for libbucket provisioner kube-object-storage/lib-bucket-provisioner#195, I was not able to work on this. Will try to fix ASAP

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@4n4nd
Copy link

4n4nd commented Jun 23, 2021

still relevant

thotz added a commit to thotz/rook that referenced this issue Aug 10, 2021
Recently lib-bucket-provisioner add support for update() API.
Include that on the obc implementation since it can be used to
update quota for OBC.

Fixes: rook#7146

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
thotz added a commit to thotz/rook that referenced this issue Aug 10, 2021
Recently lib-bucket-provisioner add support for update() API.
Include that on the obc implementation since it can be used to
update quota for OBC.

Fixes: rook#7146

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
thotz added a commit to thotz/rook that referenced this issue Aug 10, 2021
Recently lib-bucket-provisioner add support for update() API.
Include that on the obc implementation since it can be used to
update quota for OBC.

Fixes: rook#7146

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
thotz added a commit to thotz/rook that referenced this issue Aug 12, 2021
Recently lib-bucket-provisioner add support for update() API.
Include that on the obc implementation since it can be used to
update quota for OBC.

Fixes: rook#7146

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
thotz added a commit to thotz/rook that referenced this issue Aug 19, 2021
Recently lib-bucket-provisioner add support for update() API.
Include that on the obc implementation since it can be used to
update quota for OBC.

Fixes: rook#7146

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
thotz added a commit to thotz/rook that referenced this issue Aug 19, 2021
Recently lib-bucket-provisioner add support for update() API.
Include that on the obc implementation since it can be used to
update quota for OBC.

Fixes: rook#7146

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
mergify bot pushed a commit that referenced this issue Aug 24, 2021
Recently lib-bucket-provisioner add support for update() API.
Include that on the obc implementation since it can be used to
update quota for OBC.

Fixes: #7146

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
(cherry picked from commit f4bb47e)
subhamkrai pushed a commit to subhamkrai/rook that referenced this issue Oct 1, 2021
Recently lib-bucket-provisioner add support for update() API.
Include that on the obc implementation since it can be used to
update quota for OBC.

Fixes: rook#7146

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ceph main ceph tag object-bucket-claims Object Bucket Claims (OBC)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants