Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim the tool dependencies for castled #73

Closed
bassam opened this issue Oct 13, 2016 · 7 comments
Closed

Trim the tool dependencies for castled #73

bassam opened this issue Oct 13, 2016 · 7 comments
Assignees

Comments

@bassam
Copy link
Member

bassam commented Oct 13, 2016

Oct 13 22:07:02 castle00 rkt[2122]: 2016-10-13 22:07:02.895783 I | Running command: lsblk --all -n -l --output KNAME
Oct 13 22:07:02 castle00 rkt[2122]: 2016-10-13 22:07:02.895985 I | error while discovering hardware: failed to list all devices: Failed to complete lsblk all: exec: "lsblk": executable file not found in $PATH
Oct 13 22:07:02 castle00 rkt[2122]: waiting for ctrl-c interrupt...
@bassam bassam added this to the initial public release milestone Oct 14, 2016
@bassam
Copy link
Member Author

bassam commented Oct 14, 2016

I think we need to use cgo to call libblkid to solve this. We already depend on libblkdid via ceph.

@bassam
Copy link
Member Author

bassam commented Oct 14, 2016

As of #83 we now include the following tools in our containers:

RUN apk add --no-cache gptfdisk util-linux kmod coreutils grep gawk e2fsprogs btrfs-progs sudo

I'm repurposing this issue to removing unneeded tools like sudo, grep, gawk, e2fsprogs, btrfs-progs, mod and others. We should really only depend on lsblk and sgdisk for disk operations, and lsblk can be removed if needed.

@bassam bassam changed the title castled should not shell out to use lsblk Trim the tool dependencies for castled Oct 14, 2016
@bassam
Copy link
Member Author

bassam commented Oct 24, 2016

@travisn after #88 what tools do we still use?

@travisn
Copy link
Member

travisn commented Oct 25, 2016

These are the remaining called by the orchestration:

  • lsblk
  • sgdisk
  • df

There are others used by the client tool for mounting, etc.

@travisn
Copy link
Member

travisn commented Oct 27, 2016

I believe we could now get this down to two packages:

apk add --no-cache gptfdisk util-linux

@bassam
Copy link
Member Author

bassam commented Oct 27, 2016

Do you want to trim the packages then?

@travisn
Copy link
Member

travisn commented Oct 28, 2016

we actually need three packages:

  • gptfdisk for sgdisk
  • util-linux for lsblk
  • coreutils for df

If we need to trim the packages further let's open a separate ticket

@travisn travisn closed this as completed Oct 28, 2016
thotz pushed a commit to thotz/rook that referenced this issue Jun 5, 2020
don't publish vendor/ or Gopkg.lock
travisn added a commit to travisn/rook that referenced this issue Jun 26, 2020
Bug 1851311: Set the minimum rgw PGs for the metadata pools to the smaller default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants