Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert util.NewSet() to sets.NewString() #8479

Closed
leseb opened this issue Aug 4, 2021 · 1 comment · Fixed by #8584
Closed

convert util.NewSet() to sets.NewString() #8479

leseb opened this issue Aug 4, 2021 · 1 comment · Fixed by #8584
Assignees
@parth-gr
Labels
feature
Projects
v1.7

Comments

@leseb
Copy link
Member

leseb commented Aug 4, 2021

The k8s.io/apimachinery/pkg/util/sets provides the same functionality with probably more. Our code uses both util.NewSet() and sets.NewString() at the same time. Let's convert to use sets.NewString() even if less instances but provides more functionality.
@leseb leseb added this to To do in v1.7 via automation Aug 4, 2021
parth-gr added a commit to parth-gr/rook that referenced this issue Aug 18, 2021
@parth-gr
core: convert util.NewSet() to sets.NewString()
ab5c802 
Converting util.NewSet() instance to use sets.NewString() instance

Closes:rook#8479
Signed-off-by: parth-gr <paarora@redhat.com>
@parth-gr parth-gr mentioned this issue Aug 18, 2021
Merged
10 tasks
v1.7 automation moved this from To do to Done Aug 20, 2021
mergify bot pushed a commit that referenced this issue Aug 20, 2021
@parth-gr
core: convert util.NewSet() to sets.NewString()
4e764f8 
Converting util.NewSet() instance to use sets.NewString() instance

Closes: #8479
Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 1601ba1)
@parth-gr
Copy link
Member

As discussed in the call, in a separate PR, we need to remove Util Package Set.go as it will no longer be used in the code,
And also left to modify the configMap set Instance to string Instance, which was throwing err while conversion.

@parth-gr parth-gr reopened this Aug 20, 2021
v1.7 automation moved this from Done to In progress Aug 20, 2021
parth-gr added a commit to parth-gr/rook that referenced this issue Aug 24, 2021
@parth-gr
core: convert util.NewSet() to sets.NewString()
5b07dce 
Converting util.NewSet() instance to use sets.NewString() instance

Closes: rook#8479
Signed-off-by: parth-gr <paarora@redhat.com>
@parth-gr parth-gr mentioned this issue Aug 24, 2021
Merged
10 tasks
parth-gr added a commit to parth-gr/rook that referenced this issue Aug 24, 2021
@parth-gr
core: convert util.NewSet() to sets.NewString()
047ede7 
Converting util.NewSet() instance to use sets.NewString() instance

Closes: rook#8479
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Aug 25, 2021
@parth-gr
core: convert util.NewSet() to sets.NewString()
77ba1ef 
Converting util.NewSet() instance to use sets.NewString() instance

Closes: rook#8479
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Aug 25, 2021
@parth-gr
core: removing util.set package files
b1cfeb9 
We are no longer using package util.set
for creating instances,
and instead of that using sets.String package

Closes: rook#8479
Signed-off-by: parth-gr <paarora@redhat.com>
v1.7 automation moved this from In progress to Done Aug 25, 2021
mergify bot pushed a commit that referenced this issue Aug 25, 2021
@parth-gr
core: convert util.NewSet() to sets.NewString()
58bd064 
Converting util.NewSet() instance to use sets.NewString() instance

Closes: #8479
Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 77ba1ef)
mergify bot pushed a commit that referenced this issue Aug 25, 2021
@parth-gr
core: removing util.set package files
5e14cec 
We are no longer using package util.set
for creating instances,
and instead of that using sets.String package

Closes: #8479
Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit b1cfeb9)
subhamkrai pushed a commit to subhamkrai/rook that referenced this issue Oct 1, 2021
@parth-gr @subhamkrai
core: convert util.NewSet() to sets.NewString()
c559639 
Converting util.NewSet() instance to use sets.NewString() instance

Closes: rook#8479
Signed-off-by: parth-gr <paarora@redhat.com>
subhamkrai pushed a commit to subhamkrai/rook that referenced this issue Oct 1, 2021
@parth-gr @subhamkrai
core: convert util.NewSet() to sets.NewString()
0e558ac 
Converting util.NewSet() instance to use sets.NewString() instance

Closes: rook#8479
Signed-off-by: parth-gr <paarora@redhat.com>
subhamkrai pushed a commit to subhamkrai/rook that referenced this issue Oct 1, 2021
@parth-gr @subhamkrai
core: removing util.set package files
ef87c38 
We are no longer using package util.set
for creating instances,
and instead of that using sets.String package

Closes: rook#8479
Signed-off-by: parth-gr <paarora@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parth-gr parth-gr

Labels
feature
Projects
No open projects
v1.7
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: convert util.NewSet() to sets.NewString() parth-gr/rook
2 participants
@leseb @parth-gr