Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rook not support selecting mode of balancer when balancer was enabled #9062

Closed
fengjiankui121 opened this issue Oct 29, 2021 · 1 comment · Fixed by #9063
Closed

rook not support selecting mode of balancer when balancer was enabled #9062

fengjiankui121 opened this issue Oct 29, 2021 · 1 comment · Fixed by #9063
Labels
feature

Comments

@fengjiankui121
Copy link
Contributor

Is this a bug report or feature request?

  • Feature Request

What should the feature do:
rook can select mode of balancer when balancer was enabled.

What is use case behind this feature:

Environment:
@leseb
Copy link
Member

leseb commented Oct 29, 2021

Indeed Rook forces it to be upmap you can change it via the toolbox (ceph balancer mode <mode>) but on the next reconcile it will change again. I believe the reason why it's hardcoded to upmap is that Nautilus used not to enable it by default. We can easily fix this for Pacific, not enabling any mode and let Ceph do it. However, we probably won't expose that through a CR setting.

leseb added a commit to leseb/rook that referenced this issue Oct 29, 2021
@leseb
mgr: do not set the balancer mode on pacific
e6834e8 
On Pacific, Ceph's default is "upmap", so we should let it like this.
This lets the user change the mode is desired.
On Octopus though, Rook continues to force the mode to "upmap".

Closes: rook#9062
Signed-off-by: Sébastien Han <seb@redhat.com>
leseb added a commit to leseb/rook that referenced this issue Oct 29, 2021
@leseb
mgr: do not set the balancer mode on pacific
cb7cc7b 
On Pacific, Ceph's default is "upmap", so we should let it be
like this.
This lets the user change the mode is desired.
On Octopus though, Rook continues to force the mode to "upmap".

Closes: rook#9062
Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb mentioned this issue Oct 29, 2021
Merged
10 tasks
leseb added a commit to leseb/rook that referenced this issue Oct 29, 2021
@leseb
mgr: do not set the balancer mode on pacific
bccc84e 
On Pacific, Ceph's default is "upmap", so we should let it be
like this.
This lets the user change the mode is desired.
On Octopus though, Rook continues to force the mode to "upmap".

Closes: rook#9062
Signed-off-by: Sébastien Han <seb@redhat.com>
mergify bot pushed a commit that referenced this issue Oct 29, 2021
@leseb
mgr: do not set the balancer mode on pacific
adbb9e9 
On Pacific, Ceph's default is "upmap", so we should let it be
like this.
This lets the user change the mode is desired.
On Octopus though, Rook continues to force the mode to "upmap".

Closes: #9062
Signed-off-by: Sébastien Han <seb@redhat.com>
(cherry picked from commit bccc84e)
parth-gr pushed a commit to parth-gr/rook that referenced this issue Feb 22, 2022
@leseb @parth-gr
mgr: do not set the balancer mode on pacific
49eb7e9 
On Pacific, Ceph's default is "upmap", so we should let it be
like this.
This lets the user change the mode is desired.
On Octopus though, Rook continues to force the mode to "upmap".

Closes: rook#9062
Signed-off-by: Sébastien Han <seb@redhat.com>
parth-gr pushed a commit to parth-gr/rook that referenced this issue Feb 22, 2022
@leseb @parth-gr
mgr: do not set the balancer mode on pacific
ae1d4e1 
On Pacific, Ceph's default is "upmap", so we should let it be
like this.
This lets the user change the mode is desired.
On Octopus though, Rook continues to force the mode to "upmap".

Closes: rook#9062
Signed-off-by: Sébastien Han <seb@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mgr: do not set the balancer mode on pacific leseb/rook
2 participants
@leseb @fengjiankui121