Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct mount toolbox example does not work on 1.8.0 due to tini being removed and the container not running as root #9382

Closed
onedr0p opened this issue Dec 10, 2021 · 0 comments · Fixed by #9423
Closed

Direct mount toolbox example does not work on 1.8.0 due to tini being removed and the container not running as root #9382

onedr0p opened this issue Dec 10, 2021 · 0 comments · Fixed by #9423
Assignees
@parth-gr
Labels
bug
Projects
v1.8

Comments

@onedr0p
Copy link
Contributor

onedr0p commented Dec 10, 2021 •
edited

Is this a bug report or feature request?

  • Bug Report

Deviation from expected behavior:

Toolbox example does not work on 1.8.0 due to tini being removed and the container not running as root

https://github.com/rook/rook/blob/v1.8.0/deploy/examples/direct-mount.yaml

Expected behavior:

The toolbox example to work.

How to reproduce it (minimal and precise):

Try to apply this https://github.com/rook/rook/blob/v1.8.0/deploy/examples/direct-mount.yaml

File(s) to submit:

  • Cluster CR (custom resource), typically called cluster.yaml, if necessary
  • Operator's logs, if necessary
  • Crashing pod(s) logs, if necessary

To get logs, use kubectl -n <namespace> logs <pod name>
When pasting logs, always surround them with backticks or use the insert code button from the Github UI.
Read Github documentation if you need help.

Environment: N/A

  • OS (e.g. from /etc/os-release): N/A
  • Kernel (e.g. uname -a): N/A
  • Cloud provider or hardware configuration: N/A
  • Rook version (use rook version inside of a Rook Pod): 1.8.0
  • Storage backend version (e.g. for ceph do ceph -v): 16.2.6
  • Kubernetes version (use kubectl version): 1.22.4
  • Kubernetes cluster type (e.g. Tectonic, GKE, OpenShift): N/A
  • Storage backend status (e.g. for Ceph use ceph health in the Rook Ceph toolbox): N/A
@onedr0p onedr0p added the bug label Dec 10, 2021
@onedr0p onedr0p changed the title Toolbox example does not on 1.8.0 due to tini being removed and the container not running as root Toolbox example does not work on 1.8.0 due to tini being removed and the container not running as root Dec 10, 2021
@leseb leseb added this to To do in v1.8 via automation Dec 13, 2021
@travisn travisn moved this from To do to Blocking Release in v1.8 Dec 13, 2021
@parth-gr parth-gr self-assigned this Dec 14, 2021
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 14, 2021
@parth-gr
build: updating tini init command in direct mount toolbox
5934c3e 
the tini have been removed but was still present at direct mount
used the bin/bash shell in place of tini

Closes: rook#9382
Signed-off-by: parth-gr <paarora@redhat.com>
@parth-gr parth-gr mentioned this issue Dec 14, 2021
Merged
10 tasks
parth-gr added a commit to parth-gr/rook that referenced this issue Dec 14, 2021
@parth-gr
build: updating tini init command in direct mount toolbox
bd3e558 
the tini have been removed but was still present at direct mount
used the bin/bash shell in place of tini

Closes: rook#9382
Signed-off-by: parth-gr <paarora@redhat.com>
@travisn travisn changed the title Toolbox example does not work on 1.8.0 due to tini being removed and the container not running as root Direct mount toolbox example does not work on 1.8.0 due to tini being removed and the container not running as root Dec 14, 2021
@travisn travisn moved this from Blocking Release to Review in progress in v1.8 Dec 14, 2021
@travisn travisn moved this from Review in progress to Blocking Release in v1.8 Dec 14, 2021
v1.8 automation moved this from Blocking Release to Done Dec 14, 2021
mergify bot pushed a commit that referenced this issue Dec 14, 2021
@parth-gr
build: updating tini init command in direct mount toolbox
dbe0346 
the tini have been removed but was still present at direct mount
used the bin/bash shell in place of tini

Closes: #9382
Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit bd3e558)

# Conflicts:
#	deploy/examples/direct-mount.yaml
parth-gr added a commit to parth-gr/rook that referenced this issue Feb 22, 2022
@parth-gr
build: updating tini init command in direct mount toolbox
a136c98 
the tini have been removed but was still present at direct mount
used the bin/bash shell in place of tini

Closes: rook#9382
Signed-off-by: parth-gr <paarora@redhat.com>
parth-gr added a commit to parth-gr/rook that referenced this issue Feb 22, 2022
@parth-gr
build: updating tini init command in direct mount toolbox
21b0bee 
the tini have been removed but was still present at direct mount
used the bin/bash shell in place of tini

Closes: rook#9382
Signed-off-by: parth-gr <paarora@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parth-gr parth-gr

Labels
bug
Projects
No open projects
v1.8
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: updating tini init command in direct mount toolbox parth-gr/rook
2 participants
@onedr0p @parth-gr