Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update examples and base image to use ceph v16.2.9 #10275

Merged
merged 1 commit into from
May 25, 2022
Merged

build: update examples and base image to use ceph v16.2.9 #10275

merged 1 commit into from
May 25, 2022

Conversation

parth-gr
Copy link
Member

@parth-gr parth-gr commented May 17, 2022 •
edited

In release 1.9, the operator base image has been changed to
ceph v16.2.9

Signed-off-by: parth-gr paarora@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@parth-gr parth-gr requested a review from travisn May 17, 2022 07:58
@mergify
Copy link

mergify bot commented May 17, 2022

Hi @parth-gr, this pull request was opened against a release branch, is it expected? Normally patches should go in the master branch first and then be backported to release branches.

@parth-gr parth-gr force-pushed the ceph-v16.2.8 branch 2 times, most recently from d6a6619 to 095f28d Compare May 17, 2022 12:53
travisn
travisn reviewed May 17, 2022
View reviewed changes
Documentation/ceph-upgrade.md Outdated
@@ -428,7 +428,7 @@ updated we wait for things to settle (monitors to be in a quorum, PGs to be clea
MDSes, etc.), then only when the condition is met we move to the next daemon. We repeat this process
until all the daemons have been updated.

We recommend updating to v16.2.7 or newer. If you require updating **to v16.2.0-v16.2.6**,
We recommend updating to v16.2.8 or newer. If you require updating **to v16.2.0-v16.2.8**,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's actually revert this line. We want to keep the recommendation for 16.2.7 or newer, since this issue is specifically about versions 16.2.0-16.2.6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

travisn
travisn requested changes May 17, 2022
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion

@parth-gr parth-gr requested a review from travisn May 18, 2022 12:37
travisn
travisn reviewed May 18, 2022
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's actually just wait to merge it until the doc updates are merged in the next day or two.

@parth-gr
Copy link
Member Author

parth-gr commented May 19, 2022 •
edited

LGTM, let's actually just wait to merge it until the doc updates are merged in the next day or two.

Actually, it didn't affect as this PR is open against release-1.9

leseb
leseb previously requested changes May 19, 2022
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v16.2.9 hotfix was just releases so let's use it

@travisn travisn changed the title build: update examples and base image to use ceph v16.2.8 build: update examples and base image to use ceph v16.2.9 May 19, 2022
@parth-gr parth-gr requested review from travisn and leseb May 19, 2022 14:50
@travisn
Copy link
Member

travisn commented May 19, 2022

LGTM, let's actually just wait to merge it until the doc updates are merged in the next day or two.

Actually, it didn't affect as this PR is open against release-1.9

Let's just wait a couple more days to see if we can get the docs backported...

@travisn travisn added this to Review in Progress in v1.9 via automation May 24, 2022
@travisn travisn moved this from Review in Progress to Blocking Release in v1.9 May 24, 2022
@mergify
Copy link

mergify bot commented May 25, 2022

This pull request has merge conflicts that must be resolved before it can be merged. @parth-gr please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

@parth-gr
build: update examples and base image to use ceph v16.2.9
31987b9 
In release 1.9, the operator base image has been changed to
ceph v16.2.9

Signed-off-by: parth-gr <paarora@redhat.com>
@travisn travisn dismissed leseb’s stale review May 25, 2022 16:56

feedback addressed

@travisn travisn merged commit b84b953 into rook:release-1.9 May 25, 2022
@travisn travisn moved this from Blocking Release to Done in v1.9 May 31, 2022
@travisn
Copy link
Member

travisn commented May 31, 2022

@parth-gr Please also open a PR for this change in the release-1.8 branch. The bot won't be able to cherry-pick it due to the doc changes in 1.9. Thanks!

@parth-gr
Copy link
Member Author

parth-gr commented Jun 1, 2022

@parth-gr Please also open a PR for this change in the release-1.8 branch. The bot won't be able to cherry-pick it due to the doc changes in 1.9. Thanks!

Opened #10366

parth-gr
parth-gr commented Jun 1, 2022
View reviewed changes
Documentation/CRDs/ceph-cluster-crd.md
image: quay.io/ceph/ceph:v16.2.7
version: 16.2.6-0
image: quay.io/ceph/ceph:v16.2.9
version: 16.2.8-0
Copy link
Member Author

@parth-gr parth-gr Jun 1, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to update this value,
DOn't know how it is changed to .8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@leseb leseb Awaiting requested review from leseb

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v1.9
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@parth-gr @travisn @leseb